Hi, mod_qos currently uses the following syntax:
QS_SrvMaxConnExcludeIP <address>
where address is of type aa.bb.cc.dd. If you want to include a subnet, you cannot precise the mask. It's either all or nothing: e.g. : 192.168.5.10 or 192.168.5. .
Could it be possible to enhance the code so that it understands the modern subnet mask '/' notation such as 192.168.0.0/16 ? This would be more pragmatical and allow to better fine tune the addresses that have to be excluded.
There are several apache modules that have adopted this syntax. I'm sure those pieces of code could be integrated into mod_qos easily, although I'm not sure what other parts of mod_qos should be hacked to add this extension.
Comments?
Thanks!
-jose
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Right, the current implementation handles this similar to the "SetEnvIf Remote_Addr" directive and has some limitations. I'll keep this request in mind.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, this request is quite a while ago :-)
I would love this feature, and woud be even willing to implement it.
Would you accept (or let's say: check) a patch?
Suggestion: Currently, mod_qos seems to "accept" something like "1.2.3.4/27", but it "ignores" it. As people might enter it like this, because they don't read the manual: I guess that reporting an error when somebody specifies a netmask might help.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi, mod_qos currently uses the following syntax:
QS_SrvMaxConnExcludeIP <address>
where address is of type aa.bb.cc.dd. If you want to include a subnet, you cannot precise the mask. It's either all or nothing: e.g. : 192.168.5.10 or 192.168.5. .
Could it be possible to enhance the code so that it understands the modern subnet mask '/' notation such as 192.168.0.0/16 ? This would be more pragmatical and allow to better fine tune the addresses that have to be excluded.
There are several apache modules that have adopted this syntax. I'm sure those pieces of code could be integrated into mod_qos easily, although I'm not sure what other parts of mod_qos should be hacked to add this extension.
Comments?
Thanks!
-jose
Right, the current implementation handles this similar to the "SetEnvIf Remote_Addr" directive and has some limitations. I'll keep this request in mind.
Well, this request is quite a while ago :-)
I would love this feature, and woud be even willing to implement it.
Would you accept (or let's say: check) a patch?
Suggestion: Currently, mod_qos seems to "accept" something like "1.2.3.4/27", but it "ignores" it. As people might enter it like this, because they don't read the manual: I guess that reporting an error when somebody specifies a netmask might help.