mockobjects-java-users

[MO-java-users] Why does MockHttpSession.getAttribute allow only one access?

[Jeff D. <Jef...@no...>]

I'm testing out my project I found that I getting an exception on the
following code that I think perfectly fine. The implementation of
MockHttpSession only allows you to access an attribute once in the
session. If you have the following code, an exception will thrown.

if (_session.getAttribute("myAttribute") != null) {
        myAttribute = (String) _session.getAttribute("myAttribute");
} else {
    throw new missingImportantDataExecption();
}

In my test, I have

setupGetAttribute(myAttribute, "really important info");

The problem just by reading the _session.getAttribute("myAttribute") in
the test condition will eliminate the value and cause an exception at
myAttribute = (String) _ session.getAttribute("myAttribute");

I expect that what your intention is that I should have

setupGetAttribute(myAttribute, "really important info");
setupGetAttribute(myAttribute, "really important info");

to show that I plan to access the attribute twice. I doubt that many
users will anticipate this. It is just not how Servlet API works, so I
think most developer will be surprised by this..

I look forward to your comments.

Regards,

Jeff Duska

Re: [MO-java-users] Why does MockHttpSession.getAttribute allow only one access?

[Steve F. <st...@m3...>]

I realize that we're not quite solving your problems. We're working on a 
new version of the dynamic mock framework that should help with some of 
this. In the meantime, perhaps there's still something to be learned 
from this example. Would it be better to only do one lookup, and 
structured as a helper method?

   private String myAttribute() {
     Object objectAttribute = _session.getAttribute("myAttribute");
     if (null == objectAttribute) {
       throw new missingException();
     }
     return (String)objectAttribute;
   }

S.

Jeff Duska wrote:
> I'm testing out my project I found that I getting an exception on the
> following code that I think perfectly fine. The implementation of
> MockHttpSession only allows you to access an attribute once in the
> session. If you have the following code, an exception will thrown.
> 
> if (_session.getAttribute("myAttribute") != null) {
>         myAttribute = (String) _session.getAttribute("myAttribute");
> } else {
>     throw new missingImportantDataExecption();
> }