mockobjects-java-dev

RE: [MO-java-dev] splitting core

[<rin...@me...>]

Jeff,

> <rant>
> I've left the tests where they were. But none of you have come up with
> anything like a reason for no moving them in with the classes 
> they test.
> (Neatness isn't a reason!)
> </rant>

Since the test classes remain in the same package, could you document
somewhere how test classes should be named for Ant to succesfully filter
them out?

Ringo

RE: [MO-java-dev] splitting core

[<rin...@me...>]

Jeff,

(Resend to the list... Jeff, sorry for the duplicate)

>         <fileset dir=3D"${core.classes}">
>           <include name=3D"**/*Test.class" />
>           <include name=3D"**/AllTests.class" />
>         </fileset>

Ofcourse, but with "document somewhere" I didn't mean the Ant build file.
Source is not always good documentation. This is a case where I think it
isn't good documentation!

Attached you can find a patch against the head of the coding conventions
document. It adds a third top level section with some small comments on uni=
t
test code conventions together with a fix on how to specify a version tag i=
n
Java source files.

Greetings,

Ringo

Re: [MO-java-dev] splitting core

[Scott L. <sl...@sl...>]

On Mon, Apr 15, 2002 at 01:48:23PM +0200, rin...@me... wrote:
> diff -u -r1.4 coding_conventions.xml
> --- doc/xdocs/coding_conventions.xml	22 Aug 2001 10:36:45 -0000	1.4
> +++ doc/xdocs/coding_conventions.xml	15 Apr 2002 11:29:20 -0000
> @@ -226,7 +226,7 @@
>  ]]></source>
> 
>          <note>
> -          You just need to write <code>@version $Id: coding_conventions.xml,v 1.4 2001/08/22 10:36:45 vmassol Exp $</code> and CVS will
> +          You just need to write <code>@version $Id$</code> and CVS will
>            add the rest during commits
>          </note>

Hmm, that won't actually change anything unless you also disable keyword
substitution on coding_conventions.xml. I suggest "You just need to write
&#36;Id&#36;" instead, so the final output looks right and you can use
keyword substitutions elsewhere.

--
Scott Lamb

RE: [MO-java-dev] splitting core

[<rin...@me...>]

Scott,

> Hmm, that won't actually change anything unless you also 
> disable keyword
> substitution on coding_conventions.xml. I suggest "You just 
> need to write
> $Id$" instead, so the final output looks right and you can use
> keyword substitutions elsewhere.

You're right. I have overlooked it. I just found it weird that in version
1.4 of the coding conventions document the expanded version was the same to=

what you ought to write.

Ringo

RE: [MO-java-dev] splitting core

[<rin...@me...>]

Jeff,

> > Hmm, that won't actually change anything unless you also 
> > disable keyword
> > substitution on coding_conventions.xml. I suggest "You just 
> > need to write
> > $Id$" instead, so the final output looks right and 
> you can use
> > keyword substitutions elsewhere.
> 
> You're right. I have overlooked it. I just found it weird 
> that in version
> 1.4 of the coding conventions document the expanded version 
> was the same to
> what you ought to write.

Attached you find another patch against the coding conventions document tha=
t
fixes the '$Id$' keyword as per Scott's suggestion.

Ringo

RE: [MO-java-dev] splitting core

[Jeff M. <je...@cu...>]

        <fileset dir="${core.classes}">
          <include name="**/*Test.class" />
          <include name="**/AllTests.class" />
        </fileset>

On Mon, 2002-04-15 at 07:46, rin...@me... wrote:
> Jeff,
> 
> > <rant>
> > I've left the tests where they were. But none of you have come up with
> > anything like a reason for no moving them in with the classes 
> > they test.
> > (Neatness isn't a reason!)
> > </rant>
> 
> Since the test classes remain in the same package, could you document
> somewhere how test classes should be named for Ant to succesfully filter
> them out?
> 
> Ringo
> 
> _______________________________________________
> Mockobjects-java-dev mailing list
> Moc...@li...
> https://lists.sourceforge.net/lists/listinfo/mockobjects-java-dev
-- 
Jeff Martin

Memetic Engineer

http://www.custommonkey.org/