mockobjects-java-dev

Re: [MO-java-dev] Reset method in CallableAddable

[<st...@m3...>]

> What is the reset method in CallableAddable meant to do?  The Javadoc
> comment is not clear, there are no tests for any implementations of it, it
> is not used in any examples, and the implementation in the CallSequence
> class is obviously broken whatever the semantics.

Vincent added it to make some of his setup easier but, being a bit naughty,=
 did so without any tests. There is a user, so we should fix it rather than=
 drop it.

S.

Re: [MO-java-dev] Reset method in CallableAddable

[Nat P. <nat...@b1...>]

From: "Tim Mackinnon" <tim...@po...>
> I recall telling [Vincent] to rename the method to
resetAllMatchesAndExpectations
> and not use any javacdoc but he couldn't be bothered and I was tired at
the
> time.

How about renaming it to "removeAllElements" (to be very explicit) or
"clear" (to match the Java collections API)?

Cheers,
            Nat.

_______________________
Dr. Nathaniel Pryce
B13media Ltd.
http://www.b13media.com
+44 (0)7712 526 661


_______________________
Dr. Nathaniel Pryce
B13media Ltd.
http://www.b13media.com
+44 (0)7712 526 661

Re: [MO-java-dev] Reset method in CallableAddable

[Nat P. <nat...@b1...>]

In that case, the reset method in CallSequence should set callIndex to 0.

Cheers,
            Nat.
_______________________
Dr. Nathaniel Pryce
B13media Ltd.
http://www.b13media.com
+44 (0)7712 526 661

----- Original Message -----
From: <st...@m3...>
To: <moc...@li...>
Sent: Wednesday, June 11, 2003 11:08 AM
Subject: Re: [MO-java-dev] Reset method in CallableAddable



> What is the reset method in CallableAddable meant to do?  The Javadoc
> comment is not clear, there are no tests for any implementations of it, it
> is not used in any examples, and the implementation in the CallSequence
> class is obviously broken whatever the semantics.

Vincent added it to make some of his setup easier but, being a bit naughty,
did so without any tests. There is a user, so we should fix it rather than
drop it.

S.



-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.
_______________________________________________
Mockobjects-java-dev mailing list
Moc...@li...
https://lists.sourceforge.net/lists/listinfo/mockobjects-java-dev