Re: [MO-java-dev] confused about naming/sql classes

[J. J. B. <jj...@re...>]

On Tue, 2004-05-18 at 12:01, J. Joseph Benavidez wrote:
> On Tue, 2004-05-18 at 05:40, Jeff Martin wrote:
> > That's a good point. This all stems from javax.naming and javax.sql used
> > to be optional to the jdk and so sat better in j2ee. However as of
> > jdk1.3 javax.naming became part of the jdk and as of jdk1.4 to has
> > javax.sql
> > 
> > We should probably move these across, although which classes go in which
> > jars is going to depend on the jdk that being build against, which is
> > going to confuse the shit outta me.
> 
> Jeff,
> 
> I can help out with this, as I need to sort this stuff out for a
> project. I plan on looking at the build.xml file today...
> 
> Thanks,
> 
> j.joseph

Here're the modifications I've made.

1) applied the attached patch. that basically pulls out the dependence
of javax.sql.DataSource from CommonDataSource (so that it builds under
1.3), and makes the 1.3/1.4 MockDataSource classes implement
javax.sql.DataSource

2) in the patched source tree:
mv ./src/j2ee/common/com/mockobjects/naming/ src/jdk/common/com/mockobjects/
mv ./src/j2ee/common/com/mockobjects/sql/* src/jdk/common/com/mockobjects/sql/
mv ./src/j2ee/1.4/com/mockobjects/sql/MockDataSource.java src/jdk/1.4/com/mockobjects/sql/
rmdir ./src/j2ee/1.4/com/mockobjects/sql ./src/j2ee/common/com/mockobjects/sql

Builds ok (including the jpackage.org source rpm).

Any chance of incorporating these mods upstream?

Thanks,
jjmb

> 
> 
> > 
> > 
> > On Tue, 2004-05-18 at 02:59, J. Joseph Benavidez wrote:
> > > Hello,
> > > 
> > > I'm trying to figure out the mockobject packages and how they're
> > > distributed amongst the jar files.
> > > 
> > > My confusion stems from the fact that the naming.* (and some sql.*)
> > > classes are in the j2ee jars, but javax.naming.* and javax.sql.* are in
> > > the standard jdks.
> > > 
> > > Would it be possible to put those classes in their respective plain
> > > jdk1.3/jdk1.4 jars and pull them out of the j2ee jars?
> > > 
> > > Thanks,
> > > 
> > > j.joseph
> > > 
> > > 
> > >