From: Scott L. <sl...@sl...> - 2002-06-05 22:16:34
|
On Wed, Jun 05, 2002 at 11:15:56AM +0100, Jeff Martin wrote: > Probably the thing to do is inherit where possible from the common/1.3 > mocks and implement any new methods using notImplemented(); apart from > any that you may need to be fully mocked. Hmm, I was thinking more about the single copy in common implementing the additional functionality. It wouldn't accomplish anything for JDK1.3 and lower, but I don't think it would hurt anything either. I don't understand how inheriting from the others would work. Especially inheriting 1.3 stuff from 1.4 - it compiles ${src.jdk.dir}/${jdk.version} and ${src.jdk.dir}/common, so a build on 1.4 won't build the 1.3 dir. With the InterfaceImplementor stuff, this wasn't an issue for the non-implemented stuff - it just used whatever JDK you are compiling against to decide what stubs it needed. But of course, it didn't help for the more interesting, manually-produced code. I didn't worry about this since I didn't actually need to use any of the extra JDK 1.4 stuff in question, just to made it compile. > The 1.3 stuff is probably still the code that is primarily used as most > people won't have migrated to 1.4. (Least that's my experience) *nod* I guess I'm an early adopter. I particularly like a couple JDK 1.4 features, like assertions. -- Scott Lamb |