From: Tim M. <tim...@po...> - 2002-08-22 23:38:25
|
I disagree with that change Steve. I know you prefer it - but its much clearer to have a boolean parameter. It also allows for a clearer test when you explicitly use false, to communicate that you really don't want an exception. It also lets you set true in a test setup method and for an odd test set it back to false. -----Original Message----- From: moc...@li... [mailto:moc...@li...]On Behalf Of Steve Freeman Sent: 22 August 2002 10:53 To: moc...@li...; mockobjects users Subject: Re: [MO-java-dev] com.mockobjects.io.MockWriter correction I've checked this in twice. 1) more or less as you sent it. 2) invoking committer's privilege I've: - changed setWriteShouldThrowException() not to take a parameter. The idea is that new instances should be constructed for each test, so you shouldn't be toggling this value on and off. It's either the default (off) or set. - changed some variable names - changed verify() to use the Verifier helper class. If you don't like this let me know and we can rollback, in the meantime, both versions are in CVS. Steve ----- Original Message ----- From: "Francois Beausoleil" <fbe...@ft...> To: <moc...@li...> Sent: Thursday, August 22, 2002 3:08 AM Subject: [MO-java-dev] com.mockobjects.io.MockWriter correction > [...] ------------------------------------------------------- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 _______________________________________________ Mockobjects-java-dev mailing list Moc...@li... https://lists.sourceforge.net/lists/listinfo/mockobjects-java-dev --- Incoming mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.381 / Virus Database: 214 - Release Date: 02/08/2002 --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.381 / Virus Database: 214 - Release Date: 02/08/2002 |