Re: [Mockobjects-java-users] Beginner questions

[<lau...@ma...>]

On 22 Apr, Scott Lamb wrote:
> On Mon, Apr 22, 2002 at 01:25:44PM -0400, lau...@ma... wrote:
>> in the testNoMissingParameters() method, I get an error. This kinda tell=
s me
>> that I'm not setting up the servlet properly. Am I correct in my assessm=
ent?
>> What am I not understanding at this point?
>=20
> What sort of error? Your test code looked good to my semi-educated eye. A=
re
> you sure it is not working correctly and finding a bug in the code you ar=
e
> testing?
>=20

Sorry, I have to learn to speak properly; I should've said failure:

Time: 0.039
There was 1 failure:
1) testNoMissingParameters(ca.masq.servlet.ParameterParser_UnitTest)junit.f=
ramework.AssertionFailedError: Required parameter missing=20
=09at ca.masq.servlet.ParameterParser_UnitTest.testNoMissingParameters(Para=
meterParser_UnitTest.java:72)

This is my code:

    public ParameterParser(String[] requiredParams, HttpServletRequest aReq=
uest) {
        request =3D aRequest;
        if (request =3D=3D null) {
            throw new IllegalArgumentException("Null request received");
        }
        requestParameters =3D request.getParameterMap();
        requiredParameters =3D requiredParams;
    }

and the test code (I modified it a bit since my earlier post):

    public void setUp() {
        servletRequest =3D new MockHttpServletRequest();
        servletRequest.setupAddParameter("param1", "value1");
        servletRequest.setupAddParameter("param2", "value2");
        servletRequest.setupAddParameter("param3", "value3");
    }

    public void testNoMissingParameters() {
        String[] requiredParams =3D { "param1", "param2", "param3" };
        parser =3D new ParameterParser(requiredParams, servletRequest);
        assertTrue("Required parameter missing ", parser.getMissingParamete=
rs() =3D=3D null);
    }

So I expect request.getParameterMap() to return a Map containing the keys
"param1", "param2" and "param3". But when I run in the debugger, it returns
null. So I expect there's something I'm misunderstanding.

L


--=20
Laurent Duperval <mailto:lau...@ma...>

La lettre, exsangue et chiffonn=E9e, hors d'haleine mais triomphante, about=
it
enfin entre les mains de celui qui suscita toute l'extraordinaire odyss=E9e
d'=E9motion que je viens de vous narrer: MOI!
                                             -Achille Talon