#218 SimpleCache, TCPConnCache

Internals (55)

Either rewrite TCPConnCache not to use a superclass, or
rewrite SimpleCache to use the new-style
dict-subclassing, etc.


  • Zooko O'Whielacronx

    • milestone: 237928 --> v0.7
  • Zooko O'Whielacronx

    Logged In: YES

    Or maybe get rid of the concept of a dict which is a cache
    of connection objects, and instead have the connection
    objects (instances of TCPConnection) be held directly by
    Peer instances, and then write a new policy about when to
    close those connections...

  • Zooko O'Whielacronx

    • assigned_to: zooko --> tschechow
  • Nobody/Anonymous

    Logged In: NO

    please close as irrelevant.
    i do not even understand what it tries to mean, even after
    having visited the code in question recently.
    egtp can not work in a sane way without keeping all
    connections of a certain protocol in some central
    protocol-specific manager-thinigie.

    being 15 months old, perhaps its talking about a different
    EGTP than the one in 0.7?

  • Zooko O'Whielacronx

    • status: open --> closed-rejected
  • Zooko O'Whielacronx

    Logged In: YES

    Yeah, this was quite confusing because I wrote it to myself and didn't
    expect anyone else would ever try to understand EGTP implementation.

    The point was that the "TCPConnCache" class which inherited from
    "pyutil.Cache.SimpleCache" was ugly. It was one of those "Let's use
    inheritance as much as we can." mistakes.

    I'll now close this, as I don't even know if modern EGTP implementation
    uses that "TCPConnCache" class, and anyway it is baka's decision now if
    he thinks some parts ought to be rewritten.


Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.

No, thanks