Re: [Mlterm-dev-en] Bug with Vim and Cyrillic Compose Sequences

[<kec...@ke...>]

Hey,

That fixes the bug for me, at least for the compose sequence that I 
included in the repro steps in my original report.

Thank you!

  - Kelvin

On Sun, Mar 15, 2020 at 01:56:55PM +0900, Araki Ken wrote:
> Hi,
>
>kec...@ke... wrote:
>> I've encountered a bug where mlterm crashes with a buffer overflow
>> when I try to type a compose sequence consisting of cyrillic
>> characters, the first of which is lowercase and the second capital,
>> into vim running in mlterm.
>>
>> More precise steps to reproduce are:
>>
>>  - Add the line '<Multi_key> <Cyrillic_zhe> <Cyrillic_ZHE> : "TEST"' to
>>  - your ~/.XCompose file (or any sequence of a lowercase cyrillic letter
>>  - followed by a capital; all of the ones I've tried have worked).
>>    - Open mlterm and run Vim
>>
>>  - Press i to insert text into Vim, and then change keyboard to Russian
>>
>>  - Type the above compose sequence (Cyrillic zhe is usually located on
>>  - the semicolon/colon key when you use the Russian layout with an
>>  - American keyboard; for other keyboards you may need to look up the
>>  - layout and find the key before trying this)
>>
>>  - Expected behavior is that "TEST" should appear in Vim, but actual
>>  - behavior is that mlterm crashes.
>>
>> Per @arakiken's request (via Twitter), I've attached a log file
>> obtained by launching mlterm with --logseq and reproducing this
>> bug. I'm running mlterm version 3.8.9 with features otl, ssh, implugin
>> and utmp, although I've seen this bug on v3.8.1 as well (upgrading
>> didn't change anything).  My OS is Sabayon Linux, with kernel version
>> 5.4.0.
>>
>> Note that this bug *only* occurs in Vim running in mlterm; typing the
>> above compose sequence directly into mlterm works as expected.
>
> Thanks for your detailed report.
> I couln't reproduce the crash, but I found a bug which seems to be related
>to this problem.
>
> Please test https://bitbucket.org/arakiken/mlterm/get/tip.tar.gz
> (Diff: https://bitbucket.org/arakiken/mlterm/commits/fc3566fff20d05163a1b6c154e2a438e150e4e7c)
>
> If it doesn't solve this problem, will you use gdb to investigate where
>mlterm crashes ?
>
>$ gdb /foo/bar/mlterm
>(gdb) run
>... -> crashes mlterm
>(gdb) bt
>... -> Please send me this backtrace.
>
> (My environment)
> OS: Arch Linux (Kernel: 5.0.13)
> mlterm: hg head(changeset 3072), mlterm-3.8.9 or mlterm-3.8.8 (~/.mlterm is empty)
> vim: 8.2 (~/.vimrc is empty)
>
> Regards,
>---
>Araki Ken
>ara...@us...