Re: [Mlterm-dev-en] OSC1337 support for preserveAspectRatio

[Araki K. <ara...@us...>]

 Hi,

From: "Yuri D'Elia" <wa...@th...>
Subject: Re: OSC1337 support for preserveAspectRatio
Date: Sun, 11 Mar 2018 15:33:52 +0100
Message-ID: <87v...@wa...>

> On Sun, Mar 11 2018, Araki Ken wrote:
> >  Mlterm now supports OSC1337 'preserveAspectRatio' option on x11.
> >  Please check http://bitbucket.org/arakiken/mlterm/get/tip.tar.gz
> 
> I gave it a try. The image is scaled with correct ratio correctly, but
> the cropped section of the image is showing either black or garbage.
> Probably an uncleared buffer?
> 
> However iterm2 doesn't fill the blank space, as if the image was
> downscaled to begin with. I'd expect the same behavior too, in order to
> get the current background color of the terminal where there is no
> image.

 Thanks. I fixed.
 
> I also reported another issue a while ago:
> 
> use_point_size=true only works with type_engine=xft in my case.
> 
> If I leave type_engine=cairo (the default), fontsize is always in
> pixels irregardless of the status of use_point_size.
> 
> Both xrandr and the Xft.dpi xresource agree and are set to 140dpi in my
> case. Any reason cairo isn't picking it up?

 I have not come up with anything yet about this problem.

 Will you test as follows with the use of an attached patch and send me
~/.mlterm/msg.log ?

$ patch -p1 < mlterm-3.8.5-dpilog.patch
$ cd uitoolkit/libtype
$ make clean;make;sudo make install
$ mlterm -type xft -point
$ mlterm -type cairo -point

 Regards,
---
Araki Ken
ara...@us...