Re: [Mlterm-dev-en] 3.1.0 crash

[Araki K. <ara...@us...>]

 Hi,

From: Andi Cristian Serbanescu <ski...@ya...>
Subject: Re: [Mlterm-dev-en] 3.1.0 crash
Date: Thu, 10 May 2012 14:45:42 -0700 (PDT)
Message-ID: <133...@we...>

> You are right. Xterm disables the underline for plain UL only (urxvt doesn't disable it at all). But xterm also has resources to completely disable drawing underlines and bold text (underLine and allowBoldFonts).
> Initially, I had something else in mind for bold text, but maybe this can still be done as an extra option: if bd_color is not set, it would see if fg_color and ul_color are aliased to one of the default dim colours (0-7) and, if so, would handle them as if they were ordinary (ANSI) coloured text (i.e. highlight them if BD and apply RV before BD (if BD + RV), so that on the screen you would see bright (8-15) text on a dim (0-7) background). What do you think about this?

 It seems a good hack, but a little hard to understand for users.

 Instead I added --noul / "hide_underline" option which completely disables
underline like xterm as an experiment.

> > RV + anything else is black on white (plus the other
> > attributes), just as if bd_color and ul_color were not
> > defined (although they behave as expected when selected with
> > the mouse).
> > 
> >  Thanks. This is a bug.
> >  An attached patch will fix this problem.
> > 
> 
> I applied the patch, but it doesn't work :(

 I modified a little more.

 I placed a modified source tar ball at http://mlterm.sf.net/mlterm-3.1.2-pre20120512.tar.gz

 Regards,
---
Araki Ken
ara...@us...