Re: [Mlterm-dev-en] 3.1.0 crash

[Andi C. S. <ski...@ya...>]

I patched it, built it and it runs now; I am very grateful for your time in implementing these. I have tested them, but have found that they work only partially: the change only takes effect if it doesn't conflict with another attribute (with bold cancelling ul_color and reverse-video cancelling both bd_color and ul_color).

To illustrate (having set bg_color = black, fg_color = white, bd_color = hl_white and ul_color = cyan), BD and UL appear as expected, but BD + UL is underlined hl_white on black (i.e. ul_color/disable underline has no effect) and RV + anything else is black on white (plus the other attributes), just as if bd_color and ul_color were not defined (although they behave as expected when selected with the mouse).

I think these conflicts should be solved by making ul_color only set the colour of UL text, and adding a separate option to disable every instance of the underline (including coloured text), a second one to disable BD text (again, for all cases) and a third one (let's say bu_color) to choose a colour for text which is BD + UL. Also, reverse-video should take into account the actual colour of the text after setting these options.