From: Seiichi S. <ss...@sh...> - 2005-03-02 14:33:45
|
On Tue, Mar 01, 2005 at 09:24:42PM +0100, Mike FABIAN wrote: > Patch against todays CVS to fix some compiler warnings which SuSE's autobuild > won't accept is attached. > > Is that patch OK? Basically, OK. But Araki-san's coding style is: int function(void) { foo() ; return 1 ; /* anyway, return 1 (means true) */ } This way is useful for future extension like: int function(void) { foo() ; if( ! bar()) { /* bar() failed */ return 0 ; } return 1 ; } -- Seiichi |