In kiklib/src/kik_pty_streams.c _XOPEN_SOURCE is explicitly defined unless __APPLE__ is defined. This is a bad idea and doesn't match the explanatory comment. There are many Unix systems beside Mac OS X which do not use GNU libc (Solaris, NetBSD, OpenBSD, FreeBSD, HP-UX, OSF etc.) and it verifiably breaks compiling on NetBSD. Checking for GNU libc can be achieved by testing for __GLIBC__ and __GLIBC_MINOR__. It is much safer to set _GNU_SOURCE on such systems instead which will basically pull in everything available. It would be a better idea to put these 3 lines in a commonly included header file.
A patch is attached.
Log in to post a comment.