Thread: [Mlt-devel] [PATCH]: mlt 0.5.0 FTBFS on all != x86 arches
Brought to you by:
ddennedy,
lilo_booter
From: Patrick M. <pma...@de...> - 2010-02-16 17:09:24
Attachments:
01-dont_hardcode_x86.diff
|
Hello, mlt FTBFS, because in the makefile of the xine module, there is an hardcoded -DARCH_X86, see build logs: https://buildd.debian.org/build.cgi?pkg=mlt I have attached a patch. -- /* Mit freundlichem Gruß / With kind regards, Patrick Matthäi GNU/Linux Debian Developer E-Mail: pma...@de... pa...@li... Comment: Always if we think we are right, we were maybe wrong. */ |
From: Dan D. <da...@de...> - 2010-02-16 19:09:04
|
On Tue, Feb 16, 2010 at 9:09 AM, Patrick Matthäi <pma...@de...> wrote: > Hello, > > mlt FTBFS, because in the makefile of the xine module, there is an hardcoded > -DARCH_X86, see build logs: > https://buildd.debian.org/build.cgi?pkg=mlt > > I have attached a patch. This hardcoded define is not new and has already been discussed here. If you remove this define, then x86 users (99% of the users) will not get any accelerated deinterlace. The fix is different and a bit more involved. I forgot about the full build integration with new code I added to the xine module after I put the real effort into making it functional. I will respond soon with a patch for non-sse2, non-sse, and non-mmx architectures. -- +-DRD-+ |
From: Patrick M. <pma...@de...> - 2010-02-16 19:35:35
|
On 16.02.2010 20:01, Dan Dennedy wrote: > On Tue, Feb 16, 2010 at 9:09 AM, Patrick Matthäi<pma...@de...> wrote: >> Hello, >> >> mlt FTBFS, because in the makefile of the xine module, there is an hardcoded >> -DARCH_X86, see build logs: >> https://buildd.debian.org/build.cgi?pkg=mlt >> >> I have attached a patch. > > This hardcoded define is not new and has already been discussed here. > If you remove this define, then x86 users (99% of the users) will not > get any accelerated deinterlace. The fix is different and a bit more > involved. I forgot about the full build integration with new code I Okay I am with your opinion, but this breaks on != x86 architectures. so this should only be added, if the architecture is i386/amd64. > added to the xine module after I put the real effort into making it > functional. I will respond soon with a patch for non-sse2, non-sse, > and non-mmx architectures. Okay. -- /* Mit freundlichem Gruß / With kind regards, Patrick Matthäi GNU/Linux Debian Developer E-Mail: pma...@de... pa...@li... Comment: Always if we think we are right, we were maybe wrong. */ |
From: Dan D. <da...@de...> - 2010-02-17 06:02:07
Attachments:
01-deinterlace-no-mmx-sse.diff
|
On Tue, Feb 16, 2010 at 11:35 AM, Patrick Matthäi <pma...@de...> wrote: > On 16.02.2010 20:01, Dan Dennedy wrote: >> On Tue, Feb 16, 2010 at 9:09 AM, Patrick Matthäi<pma...@de...> wrote: >>> Hello, >>> >>> mlt FTBFS, because in the makefile of the xine module, there is an hardcoded >>> -DARCH_X86, see build logs: >>> https://buildd.debian.org/build.cgi?pkg=mlt >>> >>> I have attached a patch. >> >> This hardcoded define is not new and has already been discussed here. >> If you remove this define, then x86 users (99% of the users) will not >> get any accelerated deinterlace. The fix is different and a bit more >> involved. I forgot about the full build integration with new code I > > > Okay I am with your opinion, but this breaks on != x86 architectures. so > this should only be added, if the architecture is i386/amd64. > >> added to the xine module after I put the real effort into making it >> functional. I will respond soon with a patch for non-sse2, non-sse, >> and non-mmx architectures. > > Okay. Please test the attached patch. It moves that hardcoded ARCH_X86 define to a MMX-only section, and now the new YADIF code honors the SSE and SSE2 defines set by configure (including --disable overrides). -- +-DRD-+ |
From: Patrick M. <pma...@de...> - 2010-02-17 18:28:18
|
On 17.02.2010 07:02, Dan Dennedy wrote: > On Tue, Feb 16, 2010 at 11:35 AM, Patrick Matthäi<pma...@de...> wrote: >> On 16.02.2010 20:01, Dan Dennedy wrote: >>> On Tue, Feb 16, 2010 at 9:09 AM, Patrick Matthäi<pma...@de...> wrote: >>>> Hello, >>>> >>>> mlt FTBFS, because in the makefile of the xine module, there is an hardcoded >>>> -DARCH_X86, see build logs: >>>> https://buildd.debian.org/build.cgi?pkg=mlt >>>> >>>> I have attached a patch. >>> >>> This hardcoded define is not new and has already been discussed here. >>> If you remove this define, then x86 users (99% of the users) will not >>> get any accelerated deinterlace. The fix is different and a bit more >>> involved. I forgot about the full build integration with new code I >> >> >> Okay I am with your opinion, but this breaks on != x86 architectures. so >> this should only be added, if the architecture is i386/amd64. >> >>> added to the xine module after I put the real effort into making it >>> functional. I will respond soon with a patch for non-sse2, non-sse, >>> and non-mmx architectures. >> >> Okay. > > Please test the attached patch. It moves that hardcoded ARCH_X86 > define to a MMX-only section, and now the new YADIF code honors the > SSE and SSE2 defines set by configure (including --disable overrides). > It works, thanks! :) -- /* Mit freundlichem Gruß / With kind regards, Patrick Matthäi GNU/Linux Debian Developer E-Mail: pma...@de... pa...@li... Comment: Always if we think we are right, we were maybe wrong. */ |
From: Dan D. <da...@de...> - 2010-02-17 18:52:56
|
On Wed, Feb 17, 2010 at 10:27 AM, Patrick Matthäi <pma...@de...> wrote: > On 17.02.2010 07:02, Dan Dennedy wrote: >> On Tue, Feb 16, 2010 at 11:35 AM, Patrick Matthäi<pma...@de...> wrote: >>> On 16.02.2010 20:01, Dan Dennedy wrote: >>>> On Tue, Feb 16, 2010 at 9:09 AM, Patrick Matthäi<pma...@de...> wrote: >>>>> Hello, >>>>> >>>>> mlt FTBFS, because in the makefile of the xine module, there is an hardcoded >>>>> -DARCH_X86, see build logs: >>>>> https://buildd.debian.org/build.cgi?pkg=mlt >>>>> >>>>> I have attached a patch. >>>> >>>> This hardcoded define is not new and has already been discussed here. >>>> If you remove this define, then x86 users (99% of the users) will not >>>> get any accelerated deinterlace. The fix is different and a bit more >>>> involved. I forgot about the full build integration with new code I >>> >>> >>> Okay I am with your opinion, but this breaks on != x86 architectures. so >>> this should only be added, if the architecture is i386/amd64. >>> >>>> added to the xine module after I put the real effort into making it >>>> functional. I will respond soon with a patch for non-sse2, non-sse, >>>> and non-mmx architectures. >>> >>> Okay. >> >> Please test the attached patch. It moves that hardcoded ARCH_X86 >> define to a MMX-only section, and now the new YADIF code honors the >> SSE and SSE2 defines set by configure (including --disable overrides). >> > > It works, thanks! :) Excellent - I was a bit worried because the ifdef got a bit heavy in yadif.c. I will commit it tonight. Then, I will wait a bit to see if other packagers report something or some other big bug pops up before making a new release by end of month. -- +-DRD-+ |