Re: [Mlt-devel] Vignette Fix

[Marco G. <g....@fr...>]

Am 29.11.2009 um 22:45 schrieb Dan Dennedy:

> On Sun, Nov 29, 2009 at 1:06 PM, Dan Dennedy <da...@de...> wrote:
>> On Sun, Nov 29, 2009 at 6:26 AM, Marco Gittler <g....@fr...> wrote:
>>> Hi Dan
>>> 
>>> can you pull from http://github.com/gmarco/mlt/commits/vignette_fix
>>> 
>>> this allows now every parameter to be set up with extra values and does not use the geometry value anymore.
>>> 
>> 
>> Now it shows up in Kdenlive with 4 useless geometry widgets for parameters.
> 
> It is still a mess in a few ways:
> 
> - again, because it is using geometry, it expects float as a
> percentage string but does kdenlive have a general way to know to
> append a '%'?
not yet, but since radius and x,y must be in % else it will not be resolution independent, i'll convert this to float from 0-1
> - if you try to declare them as float, range 0.0 - 1.0, in the yml,
> then geometry does not parse it that way.
ok
> - parameters like smooth and opacity actually appear to be handled
> like percentages, yet they are not. ?
yes this is also 0-100% will be converted to 0-1
> - the yaml says integers with default values including a '%' suffix,
> but that is not really a valid combination. they should be converted
> from int to float in the code or declared as string in yaml.
> - the yaml includes needless 'format:' strings and lack minimum and maximum.
> - "Unsharpeness of border" is better known as "Feathering"
ok i rename this

regards marco
> 
> -- 
> +-DRD-+