Re: [Mjpeg-developer] Patch for ppmtoy4m.c

[Mark T. <ma...@tr...>]

On Friday 22 March 2002 15:59, you wrote:
>  >This change fixes ppmtoy4m output on DOS-like systems with a default
>  >CR/LF carriage return on stdout. Sorry it's not a proper patch, but
>  >it's just one line. Should be OK on all systems, but you may want to
>  >enclose it in an #ifdef, perhaps?
>
> Well, seeing as there is no setmode() on *my* system, it's definitely
>  not ok on all systems.  :)

I suppose there's no use for it on non-CRLF systems. It gave an "implicit 
declaration" warning when I compiled it, but it works now! Should be in an 
#ifdef then, or detected in the configure script.

>
> Could you give more details on your system/compilation environment?

Cygwin under Windows 98 and Windows 2000.

> Also, did you have a similar problem with any of the other yuv/y4m tools
>  in MJPEGtools?  They all use stdin/stdout the same way.  I'm surprised
>  that no one has complained about this before.

I've not tried the others. Maybe no-one esle has tried using them before, but 
the y4m file produced has 0x0D 0x0A "carriage returns" without the patch, 
which mpeg2enc won't read. It comes of just writing to fd 1 without 
initializing the mode first.

-- 
Mark.