Menu
▾
▴
[Mjpeg-users] [PATCH 0515/1285] Replace numeric parameter like 0444 with macro
|
From: Baole Ni <bao...@in...> - 2016-08-02 11:57:55
|
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chu...@in...> Signed-off-by: Baole Ni <bao...@in...> --- drivers/media/pci/zoran/zoran_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/zoran/zoran_device.c b/drivers/media/pci/zoran/zoran_device.c index 4d47dda..b34dc9e 100644 --- a/drivers/media/pci/zoran/zoran_device.c +++ b/drivers/media/pci/zoran/zoran_device.c @@ -68,7 +68,7 @@ static bool lml33dpath; /* default = 0 * load on Bt819 input, there will be * some image imperfections */ -module_param(lml33dpath, bool, 0644); +module_param(lml33dpath, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(lml33dpath, "Use digital path capture mode (on LML33 cards)"); -- 2.9.2 |