From: Gregg L. <gr...@li...> - 2005-05-17 02:24:24
|
Bruce Winter wrote: > I just finished updating Generic_Item to optionally echo out state > changes to xAP and/or xPL, depending if a mh.ini xap/xpl_enable_items > parms and/or new xAP/xPL_enable methods. > A couple of comments... 1) Would you entertain changing the check for xap_enable_items or xap_enable to an "and". Or, optionally, provide some means for globally turning off either/both w/o also turning off xap and/or xpl? 2) The xpl send defaults to a xpl-cmd--which conceptually, isn't quite right (IMO). Perhaps, instead send using: &xAP::sendXpl('mhouse.item','xpl-stat',<data>); # where <data> is the elaborated hash 3) The schema used for both xap and xpl are currently mh-specific and therefore don't actually interoperate w/ any other xap or xpl clients/senders. Is this mod really only useful to mh-to-mh synching or were you planning to introduce this schema to the corresponding groups? 4) Related to #3... might it not be possible to achieve greater xAP interoperability by extending the BSC schema w/ state_prev, set_by, and mh_target--perhaps w/ less mh-specific attribute names? > If you turn on xap_enable_items=1 and enable common/xAP_items.pl on 2 > mh systems, and share a common mht file, then the items in both > systems will be mirrored. > See #1 above--apparently, xap_enable_items can be anything if xap_enable = 1 (the default). Maybe leave xap_enable_items = 0 in mh.ini and allow it to be set to 1 in xAP_items.pl (while also changing the logical check to an "and" rather than an "or")? Also, any possibility of extending this reasonably to include support for BSC? Possibly do as now w/ some other xAP/xPL code by setting set_by to xap and leaving target undef? Also, xAP_items.pl is remarkably similar to xAP_command.pl--what about introducing support for the ackmsg attribute like xAP_command.pl does and we do away w/ the xAP_command.pl code (yes--this affects the asterisk users that target mh w/ the orig. schema)? If not "get rid of it", perhaps mark the file as "deprecated" assuming support would exist in xAP_items.pl (so as to reduce the possibility of confusion due to similar code). |