ReadyMedia / Patches / #92 Movie thumbnail support

caribouk - 2013-01-12

@Eduardo, I have had to set the seek_percentage to 25% as my recorded TV shows are around have a safety buffer of 3 mins, so for half hour shows the thumbnail generated (at 10% by default) is often the previous program or the adverts before the main show.. could the patch be amended to set this to 25%?

Also, I have a personal preference for overlay film strips and was wondering whether you would consider adding an overlay_film_strip a parameter to enable this..

Thanks

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-01-19

thumbnail_minidlna_1.0.25v3.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-01-20

summary: Thumbnail support --> Movie thumbnail support
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-01-20

caribouk, please help me test the version 3 of the patch that includes the film strip and some inotify optimization on folder rename. I´ve also uploaded a patch for the current CVS version.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-01-25

1.0.25v3.patch works fine for me, film strip included.
THX

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

caribouk - 2013-01-26

Hi Eduardo
I have tested the v3 patch, with and without filmstrip overlays and it works beautifully.

inotify also works and thumnbails are automatically generated. The folder structure on the TV does not get reloaded until I exit back to the allshare menu and select minidlna again.. but I guess that's down to some sort of caching.

Thanks for the patch...

P.S. Are you working on any further samsung related patches?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

caribouk - 2013-01-26

Oh and the 20% seek produces much better thumbnails for me !
:-)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "patches Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Patches"

Anonymous - 2013-04-06

I'm trying to apply this patch to entware minidlna and is compiling fine without errors but wil not generate thumbnails, I get this errors in log:

admin@RT-AC66U:/tmp/home/root# minidlna -f /opt/etc/minidlna.conf -d
parsing error file /opt/etc/minidlna.conf line 71 : enable_thumbnail=yes
parsing error file /opt/etc/minidlna.conf line 74 : thumbnail_width=160
parsing error file /opt/etc/minidlna.conf line 77 : thumbnail_quality=8
parsing error file /opt/etc/minidlna.conf line 80 : enable_thumbnail_filmstrip=yes
[2013/04/06 18:18:01] minidlna.c:913: warn: Starting MiniDLNA version 1.0.25 [SQLite 3.7.12.1].

Thumbnail generation are enabled at compile time, any advice please?

I'm trying to apply this patch to entware minidlna and is compiling fine without errors but wil not generate thumbnails, I get this errors in log: admin@RT-AC66U:/tmp/home/root\# minidlna -f /opt/etc/minidlna.conf -d parsing error file /opt/etc/minidlna.conf line 71 : enable\_thumbnail=yes parsing error file /opt/etc/minidlna.conf line 74 : thumbnail\_width=160 parsing error file /opt/etc/minidlna.conf line 77 : thumbnail\_quality=8 parsing error file /opt/etc/minidlna.conf line 80 : enable\_thumbnail\_filmstrip=yes \[2013/04/06 18:18:01\] minidlna.c:913: warn: Starting MiniDLNA version 1.0.25 \[SQLite 3.7.12.1\]. Thumbnail generation are enabled at compile time, any advice please?

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-04-09

Hi, after applying thumbnail_minidlna-1.1.0.patch I get the following errors:
parsing error file /etc/minidlna.conf line 70 : enable_thumbnail=yes
parsing error file /etc/minidlna.conf line 73 : thumbnail_width=160
parsing error file /etc/minidlna.conf line 76 : thumbnail_quality=8
parsing error file /etc/minidlna.conf line 79 : enable_thumbnail_filmstrip=yes
Please fix

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-04-10

If you are using the 1.1.0 patch, you should use --enable-thumbnail option at ./configure and check if you have libffmpegthumbnailer developement files in your system (see the configure output).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-04-10

I have this line in ./configure: --enable-thumbnail
Should I change something else?
http://pastebin.com/KUZJfyzt

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-04-11

This line says to the configure that you want to use the thumbnail generation. The configure program will then check if you have libffmpegthumbnailer isntalled on the system along with its .h file. Check the configure output. The message "Unable to find libffmpegthumbnailer" means that you do not have all the libffmpegthumbnailer files on your system.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-04-11

Thx for fast reply
I have libffmpegthumbnailer-dev , ffmpeg and ffmpegthumbnailer installed but ./configure output is always:
checking whether to enable video thumbnail generation using libffmpegthumbnailer... no
Here is all output http://pastebin.com/e6C8kj9c
With 1.0.25 is so simple...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-04-15

This output does not help much. Please send me the config.log content.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-04-16

Here is the config.log
http://pastebin.com/BsKKcJaE

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-04-19

Has anyone applied the 1.1.0 patch and get thumbnails working? because I installed ubuntu 12.10 x32 from scratch and still the same error.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-05-03

Adds Thumbnail support to minidlna.

thumbnail_minidlna-1.1.0v2.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-05-03

Fix the Samsung bookmarking on ES tvs

samsungES_bookmarking_minidlna-1.1.0.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Eduardo Rocha - 2013-05-03

Sorry about the delay. I haven´t had much time to work on this. I´ve just uploaded a new version using pkg-config. See if it works. If not, run the command "pkg-config --list-all" to check if you have libffmpegthumbnailer installed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-05-03

Thanks for your help, still the same error:

thx@ubuntu:~/Downloads/minidlna$ minidlnad -f /home/thx/Downloads/minidlna/minidlna.conf -d
parsing error file /home/thx/Downloads/minidlna/minidlna.conf line 74 : enable_thumbnail=yes
parsing error file /home/thx/Downloads/minidlna/minidlna.conf line 77 : thumbnail_width=160
parsing error file /home/thx/Downloads/minidlna/minidlna.conf line 80 : thumbnail_quality=8
parsing error file /home/thx/Downloads/minidlna/minidlna.conf line 83 : enable_thumbnail_filmstrip=yes

and ffmpegthumbnailer is installed:

thx@ubuntu:~/Downloads/minidlna$ pkg-config --list-all
pm-utils pm-utils - Power management scripts for suspend and hibernate
libswscale libswscale - Libav image rescaling library
libavcodec libavcodec - Libav codec library
ncurses ncurses - ncurses 5.9 library
udisks udisks - udisks storage daemon
libexif libexif - Library for easy access to EXIF data
libavutil libavutil - Libav utility library
yelp-xsl yelp-xsl - Yelp XSLT Stylesheets
menu menu - ncurses 5.9 add-on library
nautilus-sendto nautilus-sendto - Extend nautilus-sendto through plugins
vorbisfile vorbisfile - vorbisfile is a library that provides a convenient high-level API for decoding and basic manipulation of all Vorbis I audio streams
vorbis vorbis - vorbis is the primary Ogg Vorbis library
ncurses++ ncurses++ - ncurses 5.9 add-on library
vorbisenc vorbisenc - vorbisenc is a library that provides a convenient API for setting up an encoding environment using libvorbis
bash-completion bash-completion - programmable completion for the bash shell
tic tic - ncurses 5.9 add-on library
fontutil FontUtil - Font utilities dirs
ibus-table IBus-Table - Table Based Input Method Framework for Intelligent Input Bus for Linux / Unix OS
usbutils usbutils - USB device database
mobile-broadband-provider-info mobile-broadband-provider-info - Mobile Broadband Service Provider Information Database
iso-codes iso-codes - ISO country, language, script and currency codes and translations
id3tag id3tag - ID3 tag reading library
libavformat libavformat - Libav container format library
xorg-wacom xorg-wacom - X.Org Wacom Tablet driver.
tinfo tinfo - ncurses 5.9 terminal interface library
openssl OpenSSL - Secure Sockets Layer and cryptography libraries and tools
panel panel - ncurses 5.9 add-on library
udev udev - udev
sqlite3 SQLite - SQL database engine
libcrypto OpenSSL-libcrypto - OpenSSL cryptography library
notify-python notify-python - Python bindings for libnotify
expat expat - expat XML parser
libssl OpenSSL - Secure Sockets Layer and cryptography libraries
libffmpegthumbnailer libffmpegthumbnailer - Generates thumbnails for movie files
shared-mime-info shared-mime-info - Freedesktop common MIME database
xbitmaps X bitmaps - Bitmaps that are shared between X applications
ogg ogg - ogg is a library for manipulating ogg bitstreams
gnome-icon-theme gnome-icon-theme - A collection of icons used as the basis for GNOME themes
form form - ncurses 5.9 add-on library
zlib zlib - zlib compression library
libquvi-scripts libquvi-scripts - Scripts for libquvi
flac FLAC - Free Lossless Audio Codec Library
xkeyboard-config XKeyboardConfig - X Keyboard configuration data
dbus-python dbus-python - Python bindings for D-Bus

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-05-03

This is the config.log http://pastebin.com/AgKYS6ja

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-05-13

Another thing, when I run ./configure it's not checking for:
checking whether to enable video thumbnail generation using libffmpegthumbnailer... no
like in 1.0.25, maybe this could be the issue

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

TeHashX - 2013-05-17

I finally managed to make it work, all I have to do was to add --enable-thumbnail after ./configure

./configure --enable-thumbnail

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "patches Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Patches"

Anonymous - 2013-05-18

great patch, seems to work nice here for now. thank you
Don't understand why this nice feature is not included...

Last edit: Anonymous 2017-11-12

great patch, seems to work nice here for now. thank you Don't understand why this nice feature is not included...

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

richud - 2013-11-02

@eduardo, great patch, few problems though!

It is segfaulting for me with certain files, e.g. 'big_buck_bunny_480p_h264.mov', from http://mirror.bigbuckbunny.de/peach/bigbuckbunny_movies/big_buck_bunny_480p_h264.mov

http://pastebin.com/Nb4YaKx4

I assume this is a fault with ffmpegthumbnailer - is there anything you can do regarding passing options to it?

Also it tries the scan the file as soon as inotify sees it created, rather than when it is all copied (Can you use inotify IN_CLOSE_WRITE to trigger instead?)

2) If a file is renamed and then scanned it seems to segfault too, this file here (good source of test files) http://www.auby.no/files/video_tests/h264_1080p_hp_4.1_10mbps_dts_unstyled_subs_monsters.mkv

http://pastebin.com/kgaggy3D

3)update while this patch is a great idea there are many files that ffmpegthumbnailer (or avcodec) fails on breaking the scanning (kills minidlnad thread), changing the thumb size by a few pixels can be enough to make certain files work or fail.

4)appears to be bug in patch, think this is the mistake & correction.

if (runtime_vars.thumb_width > 30)

runtime_vars.thumb_quality = 30;

if (runtime_vars.thumb_quality > 10)

runtime_vars.thumb_quality = 10;

Last edit: richud 2013-11-10
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Movie thumbnail support

Group

Searches

Help

#92 Movie thumbnail support

Related

Discussion