#75 more sensible severity levels for startup errors

open-accepted
5
2012-02-25
2012-02-23
No

this patch changes the severity of some error messages that might occur on startup, in a way that I think is more sensible and more in line with what one might expect.

some warnings are now just informational messages (e.g. the minidlna startup message), whereas some errors are now fatal and prevent the execution to continue (missing argument to a command-line option that requires one, inability to read the configuration file or clear the old cache, error interpreting
options in the conf file, etc.). I believe it makes more sense to exit() (through DPRINTF), rather than continuing anyway.

Discussion

  • Justin Maggard

    Justin Maggard - 2012-02-25
    • status: open --> open-accepted
     
  • Justin Maggard

    Justin Maggard - 2012-02-25

    I've checked in the ones I agree with.

    I don't like the idea of quitting due to an unsupported config file option, because over time they tend to change. Samba and many other widely-used daemons do the same thing (throw an error but continue to run), and I prefer it that way.

    Reducing the warn messages to info I agree with, but before doing that, the info messages need to be re-examined and the default log level needs to change to info.

     

Log in to post a comment.