#51 Samsung subtitle / caption menu support

closed-fixed
5
2014-05-24
2011-08-06
Anonymous
No

Patch to enable subtitle menu (or caption menu) in Samsung TVs. For any video with valid srt file present in same folder (same name as video file), press Tools button and you will see a new entry in the menu called "Subtitle options" allowing to make various changes to subtitles e.g. disable/enable, size, color, etc..
Tested with LA40C550. Please try on other devices and let me know

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-06
     
    Last edit: Anonymous 2013-11-21
  • garanda

    garanda - 2011-08-07

    Everything works great with this patch, I've tested in my Samsung C650 and the subtitles menu shows properly. The only thing that doesnt work is size, color, but i think that is because its Samsung version, or firmware doesnt support it.

    Thanks Man!! Now I have my minidlna like always dreamed.

     
  • Allan

    Allan - 2011-08-09

    The good news: On my C7000, subtitles show up under the Tools menu and the the on/off toggle, the subtitle encoding and size menu items all appear to function.

    The bad news: The patch seems to have completely broken minidlna on my BDC-5900. Prior to the patch, I got the same choice of "All Videos" and "Folders" at the first level, as with the C7000*. Now, I get 6 menus (Album, Artist, Genre, etc), and none of the menus contains anything.

    Installed as follows: deleted existing source code directory, replaced with up to date source code from CVS, applied patch, stopped minidlna, moved new binary to /usr/sbin/, started minidlna.

    *(I would be very happy to go straight to Folders, by the way, without this intermediate step. I will, under no conceivable circumstances, ever go to "All Videos").

     
  • Allan

    Allan - 2011-08-09

    I should have listed all of the menus now shown on the BDC-5900 under Videos:
    - Album, Artist, Genre, All Music, Folders, Playlists.

    Tes, that is "All Music".

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-09

    Thanks for the feedback, garanda and nxnw.

    @nxnw: If this patch is breaking the browsing, I think I know how to fix it. Will update the patch as soon as I get time (going out of town tomorrow so not sure if it will be before 20th August)..
    If someone else wants to update the patch before i return, basically the idea is that we can further divide the samsung detection into tv and blu ray player. currently both of them come under SEC_HHP_ user agent. This can be divided to SEC_HHP_TV and SEC_HHP_BD respectively as these are the strings reported by them. Then we can add the sub menu related strings to rootDesc only if SEC_HHP_TV is detected.

     
  • Leon Botha

    Leon Botha - 2011-08-09

    Hi shantanu

    I also have issues on my Home Theatre - HT-C5500 with the patch breaking the browsing.
    I have also seen that the - UserAgentSearch=SEC_HHP_HTS-C5500/1.0.

    Regards
    Leon

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-10

    Hi everybody,

    It's a well known issue with Samsung TV's & miniDLNA. I have a NAS (Seagate Go Flex Home) with miniDLNA v17 preinstalled on it. It doesn't have the "make" command installed on it. So I couldn't compile and couldn't try the patch.
    I hope, Justin Maggard will add this patch for next release of miniDLNA. So Seagate can deliver this ability to our NAS devices & TV's, hopefully.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-20

    New patch to solve samsung bd/HTS issues. Done against 21Aug CVS

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-20

    Hi Guys
    I've made the changes to make sure that the new abilities are sent only for Samsung TVs and not for BD players, Home theater systems. So the new patch should now work well for all devices. I've also rebased it against the latest CVS as of today (21 aug)

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-22

    So, thanks for this work shantanu, well done!
    I wasn't messing up with minidlna for a while , using the old anduras mega patch , on my DNS-320 nas on samsung c670 tv.
    I decide to update to last cvs using this patch with this results:
    - subtitles working , subs menu working , only external srt , no embedded subs in mkv are shown
    - resume play (the blue d button) working
    - thumbnails for files working , if present. I had those coming from the previous anduras patch.
    no thumbnails is created if not present obviously. (for now :)
    - no chapter

    It would be nice to have back chapters and thumbnails creation, but maybe in another folder, that would be great.
    Anyway I cross compile through optware system and I can provide arm biaries or ipk if someone is interested let me know.
    thank you very much

     
  • Leon Botha

    Leon Botha - 2011-08-22

    Hi shantanu

    Tested on C650 TV and HT-C5500 Home Theatre.
    Home Theatre file structure is now working correct, still no resume function from Samsung.....
    TV working as per patch

    Thank you

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-23

    Thanks for the feedback, Zodiac :)

     
  • Justin Maggard

    Justin Maggard - 2011-08-26

    Thanks for taking the time to rework the patch and test it. I'm a little hesitant on that patch though, because it adds those entries on all description XML, not just the root description. Can you please try out the patch I just posted? It takes a slightly different approach, and should only change the root device description.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-27

    Jim's patch seems to work fine here , samsung c670 tv

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-27

    I mean Justin's patch of course..just woke up, sorry :)

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-08-28

    Thanks, Justin. Your reworked patch works fine with my Samsung LA40C550.

     
  • Allan

    Allan - 2011-08-31

    Does it matter whether the patch is applied to 1.0.21 or 1.0.22?

     
  • Justin Maggard

    Justin Maggard - 2011-08-31
    • status: open --> closed-fixed
     
  • Justin Maggard

    Justin Maggard - 2011-08-31

    The patch should apply to either. I've now merged these changes into CVS.

     
  • machitza

    machitza - 2014-05-24

    can anyone provide a compiled version of this one patched for arm dns320? a have a HT F4550 bd player and i can't get it working... tried 2 and 3 patch.

     

Log in to post a comment.