Menu

#171 Use primary group of specified user

Unstable (example)
open
nobody
None
5
2021-12-19
2017-10-04
No

Commit 7a27ce introduced a command line option to set group. Is it necessary?

What do you think about the attached patch? (reverting the above commit first)

I think it matches better what users would expect when they set an user: it will also change to the primary group of that user.

1 Attachments

Discussion

  • Shrimpkin

    Shrimpkin - 2017-10-06

    I am not the project owner and cannot say if it is necessary or not. Having different user/group names can be helpful with more complex file sharing needs. Especially since minidlna is only able to limit which files are served by their permissions.

     
  • Marcos Mello

    Marcos Mello - 2017-10-07

    Sure. Traditionally this is done changing the user's primary group.

     
  • Marcos Mello

    Marcos Mello - 2017-10-07

    Separate setgid() error handling. No functional change.

     
  • Marcos Mello

    Marcos Mello - 2017-12-12

    Commit ad5d64 added this feature. But files (pidfile dir, pidfile, db_path) created before setuid/setgid still need ownership change to the new gid. Attached patch does that.

     

Log in to post a comment.