#60 Custom Server Icon

open
nobody
None
5
2016-05-27
2011-12-17
No

The advertised server icon is statically hard coded in the icons.c source file. There should be a way to customize the icon to visually differentiate servers. The internal icons could remain as fallback option. I have a small trivial patch to add this feature but it isn't all clean, the real thing should use a configuration directive for where to look for the icons.

Related

Feature Requests: #60

Discussion

  • Vanista Herion

    Vanista Herion - 2011-12-17

    Initial draft for custom icon

     
  • Mike Nerone

    Mike Nerone - 2012-03-21

    I'd also really appreciate this feature.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-06-05

    Another +1 for this feature.

     
  • Steve Messer

    Steve Messer - 2013-02-08

    I would like to see this as well.

     
  • Joe

    Joe - 2014-02-27

    I've created a patch for this feature.
    icons.c - removed.
    added config option - icons_dir=/var/cache/minidlna/icons
    icons supported;
    lrg.{png,jpg} - 120x120 24bit
    sm.{png,jpg} - 48x48 24bit

     
    Last edit: Joe 2014-02-27
  • Leonardo Fernandes

    Hello friends, i've a little mistake. I've Ubuntu 16.04 LTS, and i intalled the minidlna 1.1.5 by command apt-get install minidlna, but i would like to change de icon tha i see on my plays, like tvs, smartphones, because the icon show the debian icon. I would like to change by icon that created by me. Someone could help me?

     
    • Joe

      Joe - 2016-05-24

      'sudo apt-get remove minidlna', then compile from source and include my
      patch before ./configure.
      On May 25, 2016 4:51 AM, "Leonardo Fernandes" lndleo@users.sf.net wrote:

      Hello friends, i've a little mistake. I've Ubuntu 16.04 LTS, and i
      intalled the minidlna 1.1.5 by command apt-get install minidlna, but i
      would like to change de icon tha i see on my plays, like tvs, smartphones,
      because the icon show the debian icon. I would like to change by icon that
      created by me. Someone could help me?


      Status: open
      Group:
      Created: Sat Dec 17, 2011 10:39 PM UTC by Vanista Herion
      Last Updated: Thu Feb 27, 2014 06:09 AM UTC
      Owner: nobody

      The advertised server icon is statically hard coded in the icons.c source
      file. There should be a way to customize the icon to visually differentiate
      servers. The internal icons could remain as fallback option. I have a small
      trivial patch to add this feature but it isn't all clean, the real thing
      should use a configuration directive for where to look for the icons.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/minidlna/feature-requests/60/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Feature Requests: #60

  • Leonardo Fernandes

    My apologize, i just now the basic in the linux. Could you be o little more especific, because i don't know how i can compile and put you patch. thank you so much for your help!

     
  • Leonardo Fernandes

    I see some tutorials of compilation on Linux and I did follow steps.:
    Download minidlna from here.
    tar -xvzf minidlna-1.1.5.tar.gz
    Copy the user_icons.diff to inside minidlna-1.1.5

    So now I don't how I run your patch before ./configure.

    Thank you for your help!

     
  • Leonardo Fernandes

    I put this code

    patch < user_icons.diff

    but show some errors

    patching file config.h.in
    patching file configure
    Hunk #1 succeeded at 766 (offset 20 lines).
    Hunk #2 succeeded at 10283 (offset 504 lines).
    patching file configure.ac
    Hunk #1 succeeded at 519 (offset 28 lines).
    patching file minidlna.conf
    Hunk #1 FAILED at 5.
    1 out of 1 hunk FAILED -- saving rejects to file minidlna.conf.rej
    patching file minidlna.conf.5
    patching file minidlna.c
    Hunk #1 succeeded at 581 (offset 32 lines).
    Hunk #2 succeeded at 761 (offset 44 lines).
    patching file options.c
    patching file options.h
    Hunk #1 succeeded at 44 (offset -1 lines).
    patching file upnpglobalvars.c
    Hunk #1 succeeded at 86 (offset -1 lines).
    patching file upnpglobalvars.h
    Hunk #1 succeeded at 227 (offset 1 line).
    patching file upnphttp.c
    Hunk #1 succeeded at 87 with fuzz 2 (offset 1 line).
    Hunk #2 FAILED at 1256.
    1 out of 2 hunks FAILED -- saving rejects to file upnphttp.c.rej

     
  • Shrimpkin

    Shrimpkin - 2016-05-27

    The patch is quite old. You can try fixing, ask author to update patch, or look for another icon patch. Look around the forum and check out other forks.

     

Log in to post a comment.