Menu

minidlna 1.3.3 thumbnail configure

Help
HPP8140
2023-08-21
2023-11-07
  • HPP8140

    HPP8140 - 2023-08-21

    Hi,
    Planning to update from 1.1.2 to 1.3.3 because I am upgrading to Debian Bookworm and cannot get 1.1.2 to build.

    Question: How to we enable thumbnail in 1.3.3? I don't see the enable_thumbnail option in configure? Is there 1.3.3 thumbnail patch?

    Build:
    ./autogen.sh
    ./configure --enable-thumbnail
    make

    Thanks

     
  • paul

    paul - 2023-08-21
     
    🎉
    1
    • HPP8140

      HPP8140 - 2023-08-21

      Wow appreciate the quick response. Thanks for keeping us up to date; otherwise, this would have been a show stopper for me! I was able to build 1.3.3 and test a video thumbnail.

      After 10yrs using 1.1.2, I expected the thumbnail feature to be integrated into the main code by now...don't understand.

      Now I need to integrate back all my customizations from 1.1.2 into 1.3.3, some parts have changed drastically, but noticed bookmarks is broken again on my Samsung F series tv.

      patch --dry-run -p1 < video_thumbnail-minidlna-1.3.3-thumb.patch
      checking file aclocal.m4
      checking file albumart.c
      checking file autom4te.cache/output.2
      checking file autom4te.cache/requests
      checking file autom4te.cache/traces.2
      checking file configure
      checking file configure.ac
      checking file Makefile.am
      checking file minidlna.c
      checking file minidlna.conf
      checking file minidlnatypes.h
      checking file monitor.c
      checking file monitor_inotify.c
      checking file options.c
      checking file options.h
      checking file upnpglobalvars.h
      checking file utils.c
      checking file utils.h
      
      patch -p1 < video_thumbnail-minidlna-1.3.3-thumb.patch
      patching file aclocal.m4
      patching file albumart.c
      patching file autom4te.cache/output.2
      patching file autom4te.cache/requests
      patching file autom4te.cache/traces.2
      patching file configure
      patching file configure.ac
      patching file Makefile.am
      patching file minidlna.c
      patching file minidlna.conf
      patching file minidlnatypes.h
      patching file monitor.c
      patching file monitor_inotify.c
      patching file options.c
      patching file options.h
      patching file upnpglobalvars.h
      patching file utils.c
      patching file utils.h
      
      -------
      
      minidlna-1.3.3
      ./configure --enable-thumbnail
      
      checking for libavutil/avutil.h... yes
      checking for ffmpeg/libavutil/avutil.h... no
      checking for libav/libavutil/avutil.h... no
      checking for avutil.h... no
      checking for ffmpeg/avutil.h... no
      checking for libav/avutil.h... no
      checking for libavcodec/avcodec.h... yes
      checking for ffmpeg/libavcodec/avcodec.h... no
      checking for libav/libavcodec/avcodec.h... no
      checking for avcodec.h... no
      checking for ffmpeg/avcodec.h... no
      checking for libav/avcodec.h... no
      checking for libavformat/avformat.h... yes
      checking for ffmpeg/libavformat/avformat.h... no
      checking for libav/libavformat/avformat.h... no
      checking for avformat.h... no
      checking for ffmpeg/avformat.h... no
      checking for libav/avformat.h... no
      checking for jpeglib.h... yes
      

      Am I missing something with ffmpeg above? Lots of no.

      Here's what I have installed:
      apt-get install libavutil-dev, libavformat-dev libjpeg-dev libsqlite3-dev libexif-dev libid3tag0-dev libogg-dev libvorbis-dev libflac-dev, libffmpegthumbnailer-dev

       

      Last edit: HPP8140 2023-08-21
    • Barak A. Pearlmutter

      Wow that is fantastic, thanks.

      I've incorporated that patch into the Debian package, source package minidlna, version 1.3.3+dfsg-0.2, file debian/patches/15-thumbnails.patch. I'm not the official maintainer, so that's just a Non-Maintainer-Upload. Currently in debian/unstable, should migrate to debian/testing in a few days.

      If there's anyone who would test its functionality, that would be great! Please file on bugs.debian.org if you find any issues, although of course you can also report here if you're sure it's an issue in the thumbnail code per-se.

      Two loose ends. First, it would be nice if this were "upstreamed" of course. Second, I'm not sure what to put in the patch header: there's a place for an author, date, maybe a pointer to a git repo, stuff like that so people can track it down for updates or to share fixes and such.

       

Log in to post a comment.