#312 Album name collision

[Tobias Forsberg]

If you have two music albums with the same title (e.g. Greatest Hits) they will be treated as a single album when browsing albums. Also when browsing via artist the album cover will be the same for all albums of the different artists.

[Shrimpkin]

This first issue is related to the scanner cache. A few of workarounds:
1) Tag unique album names. Ex: Greatest Hits (Guns N Roses).
2) If using inotify, simply remove and readd affected albums one by one.
3) Apply this patch. Cache will not work for Various Artists albums.

diff --git a/scanner.c b/scanner.c
index a730567..414b219 100644
--- a/scanner.c
+++ b/scanner.c
@@ -248,7 +248,7 @@ insert_containers(const char *name, const char *path, const char *refID, const c

                if( album )
                {
-                       if( valid_cache && strcmp(album, last_album.name) == 0 )
+                       if (valid_cache && !strcmp(album, last_album.name) && !strcmp(artist, last_artist.name))
                        {
                                last_album.objectID++;
                                //DEBUG DPRINTF(E_DEBUG, L_SCANNER, "Using last album item: %s/%s/%X\n", last_album.name, last_album.parentID, last_album.objectID);

Provide additional info on the album art.

[Tobias Forsberg]

Thanks

Tobias

On Oct 23, 2017 10:14 PM, "Shrimpkin" shrimpkin@users.sf.net wrote:

This first issue is related to the scanner cache. A few of workarounds:
1) Tag unique album names. Ex: Greatest Hits (Guns N Roses).
2) If using inotify, simply remove and readd affected albums one by one.
3) Apply this patch. Cache will not work for Various Artists albums.

diff --git a/scanner.c b/scanner.cindex a730567..414b219 100644--- a/scanner.c+++ b/scanner.c@@ -248,7 +248,7 @@ insert_containers(const char name, const char path, const char *refID, const c

            if( album )
            {-                       if( valid_cache && strcmp(album, last_album.name) == 0 )+                       if (valid_cache && !strcmp(album, last_album.name) && !strcmp(artist, last_artist.name))
                    {
                            last_album.objectID++;
                            //DEBUG DPRINTF(E_DEBUG, L_SCANNER, "Using last album item: %s/%s/%X\n", last_album.name, last_album.parentID, last_album.objectID);

Provide additional info on the album art.

• [bugs:#312] https://sourceforge.net/p/minidlna/bugs/312/ Album name
  collision*

Status: open
Group: v1.0 (example)
Created: Thu Oct 19, 2017 05:17 PM UTC by Tobias Forsberg
Last Updated: Thu Oct 19, 2017 05:17 PM UTC
Owner: nobody

If you have two music albums with the same title (e.g. Greatest Hits) they
will be treated as a single album when browsing albums. Also when browsing
via artist the album cover will be the same for all albums of the different
artists.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/minidlna/bugs/312/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/