#287 Add MLang API for international and multilingual issues

Patch_committed
closed
w32api (251)
2006-03-27
2006-03-23
No

------ ChangeLog ------
2006-03-22 Hansres Engel <engel@node.ch>

* Add MLang API for international and multilingual issues
mlang.h: New file, implements most MLang declarations

------ Notes ---------
Based on
http://msdn.microsoft.com/library/default.asp?url=/workshop/misc/mlang/mlang.asp

Values for 6 constants "MAX_..." found in
http://source.winehq.org/source/include/mlang.idl

Discussion

  • Hans-Andreas Engel

    include/mlang.h: Implements MLang API

     
  • Danny Smith

    Danny Smith - 2006-03-26

    Logged In: YES
    user_id=11494

    Hello Hansres,
    There are problems with usage of THIS_ macro in several
    COM structure definitions. Attached patch resolves the
    problems, but I don't know if it is correct--I'm just
    going by the usual pattern found in these structs.

    Could you please recheck?

    Danny

     
  • Danny Smith

    Danny Smith - 2006-03-26
    • assigned_to: nobody --> jrfonseca
     
  • Danny Smith

    Danny Smith - 2006-03-26
    • assigned_to: jrfonseca --> dannysmith
     
  • Danny Smith

    Danny Smith - 2006-03-26

    Logged In: YES
    user_id=11494

    Ooops, an obvious mistake in my first patch; try the
    second.
    Danny

     
  • Danny Smith

    Danny Smith - 2006-03-26
     
  • Hans-Andreas Engel

    Logged In: YES
    user_id=1164183

    Danny,
    thank you for carefully reviewing and for checking in my
    patches!

    You are right, I should have used |f(THIS)| instead of
    |f(THIS_)| for interface methods |f(void)|. The modified
    clone methods look reasonable as well; note that according
    to MSDN they are not implemented anyway.

    Also the modified header works well when building
    mozilla/firefox.

    Best,
    Hansres

     
  • Danny Smith

    Danny Smith - 2006-03-27
    • milestone: --> Patch_committed
    • status: open --> closed
     
  • Danny Smith

    Danny Smith - 2006-03-27

    Logged In: YES
    user_id=11494

    Your patch has been accepted and is now commited to CVS. You should expect to see it in the next release.