#168 msacm.h - new header

closed-accepted
nobody
w32api (251)
2004-04-20
2003-09-15
aditsu
No

here's a header file for accessing a tiny part of the
ACM (audio compression manager) functions
please consider that it's my first attempt to
contribute some code to this project, so I'm clumsy
about the style, conventions and procedures
I'm sure this file will require changes, and I'll do
them as soon as you tell me what to do
the information sources I used for writing this file
are documented in comments inside the file

I first posted the code on the mingw-users list, refer to:
http://article.gmane.org/gmane.comp.gnu.mingw.user/8578/
http://article.gmane.org/gmane.comp.gnu.mingw.user/8577/
for more details

thank you for your attention

Adrian

Discussion

  • aditsu

    aditsu - 2003-09-15

    msacm.h - new header file

     
  • alan johnson

    alan johnson - 2004-03-15

    Logged In: YES
    user_id=943591

    this i think we could check
    over

     
  • Luke Dunstan

    Luke Dunstan - 2004-04-18

    Logged In: YES
    user_id=30442

    Thanks for the patch. I know this is a very late reply, but I
    have the following suggestions for your patch:

    1. Use only C style comments (/* ... */) not C++ (//).

    2. To be consistent with other w32api headers, put the
    extern "C" around the whole header not just the function
    prototypes.

    3. Again for consistency, don't spread the prototypes over
    multiple source lines.

    4. Check msacm32.def and create prototypes for the ANSI
    and Unicode versions of each function, even if the prototypes
    are the same. Then add a block at the end of the header:

    #ifdef UNICODE
    #define acmFormatEnum acmFormatEnumW
    #define acmDriverDetails acmDriverDetailsW
    ...
    #else
    #define acmFormatEnum acmFormatEnumA
    #define acmDriverDetails acmDriverDetailsA
    ...
    #endif

    Put all these #defines together (see for example winbase.h)

    5. For future patches submit a ChangeLog entry like this:

    2004-04-18 Adrian Sandor <aditsu@users.sourceforge.net>

    * include/msacm.h: New file.

     
  • aditsu

    aditsu - 2004-04-19

    modified msacm.h

     
  • aditsu

    aditsu - 2004-04-19

    Logged In: YES
    user_id=682737

    I'm glad to know that someone actually reads these things :)
    I modified the file using your suggestions.
    Some comments:

    > 4. Check msacm32.def and create prototypes for the ANSI
    and Unicode versions of each function

    I checked it but haven't added all the prototypes yet, but
    only the unicode versions of the prototypes I already wrote.
    I will probably add the other ones later.

    > 5. For future patches submit a ChangeLog entry like this:
    > 2004-04-18 Adrian Sandor <aditsu@users.sourceforge.net>
    > * include/msacm.h: New file.

    Dumb question: how do I submit a ChangeLog entry? And should
    I do that only for new patches, or for any modification like
    this one?

    I also removed the #include <windows.h> to make it
    consistent with other headers (e.g. shellapi.h) which
    require windows.h to be already included, and I identified
    the values of a couple more #defined constants.

    Adrian

     
  • Luke Dunstan

    Luke Dunstan - 2004-04-20

    Logged In: YES
    user_id=30442

    Thanks, I've committed your patch. By "submit" a ChangeLog
    entry I just mean write one in the description of your patch
    or at the top of a diff file. Please see the ChangeLog file in
    the w32api source for examples of the format, including for
    modifications rather than additions. CVS is here:

    http://sources.redhat.com/cgi-
    bin/cvsweb.cgi/src/winsup/w32api/?cvsroot=src

     
  • Luke Dunstan

    Luke Dunstan - 2004-04-20
    • status: open --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks