From: koala01 <ko...@fr...> - 2010-02-10 19:53:55
Attachments:
rand_s.patch
|
Hi there, According to http://msdn.microsoft.com/en-us/library/sxtz2fa8%28VS.80%29.aspx , rand_s is a secured version of rand wich is, eg, needed for OpenMpi. Can i suggest to apply the following patch to make it usable in the crt ? Thanks before |
From: Keith M. <kei...@us...> - 2010-02-10 21:07:08
|
On Wednesday 10 February 2010 19:53:19 koala01 wrote: > According to > http://msdn.microsoft.com/en-us/library/sxtz2fa8%28VS.80%29.aspx , > rand_s is a secured version of rand ... Secured, in what respect? Anyway, that reference also states that this function is not supported prior to WinXP; this... > Can i suggest to apply the following patch to make it usable in > the crt ? does not suffice, because it lacks version guards appropriate to MinGW's default build case, which is backward compatible to WinNT4 and Win9x. Some additional comments: 1) Patches need to go to the patch tracker, so they can pass through a standard review and acceptance process; those posted here may be lost. (See http://mingw.org/wiki/SubmitPatches). 2) A ChangeLog (in GNU Coding Standards format) is required. 3) Much of your patch does no more than remove extraneous trailing whitespace; while this may be tidier, it isn't necessary, and it tends to obfuscate the real content of the patch, so detracts from its quality, and may potentially hinder the review process. Patches to clean up formatting issues, such as extraneous white space, are better submitted as separate entities, clearly identified as such. 4) The MSDN page you quote also states that the documentation it provides is specific to more recent VS releases than the VS-6 documentation we normally prefer; can you confirm that this function is available with the *standard* MSVCRT provided with WinXP itself, or does it require one of MSVCR70/80/90? Thank you for your interest in enhancing MinGW; if you can address the above, I can see no reason why we would not accept a modified version of your patch. -- Regards, Keith. |