From: SourceForge.net <no...@so...> - 2008-07-09 20:14:11
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Settings changed) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Nobody/Anonymous (nobody) >Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-09 23:35:29
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) >Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-10 01:13:57
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-10 12:32:23
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by earnie You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-10 20:43:01
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-07-10 13:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 05:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-10 23:40:49
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by earnie You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Earnie Boyd (earnie) Date: 2008-07-10 19:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 16:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-11 00:13:57
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-07-10 17:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 16:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 13:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 05:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-26 01:56:37
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 21:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 20:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 19:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 16:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-27 22:29:22
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-07-27 15:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 18:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 17:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 16:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 13:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 05:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-28 02:32:36
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-27 22:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 18:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 21:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 20:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 19:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 16:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-28 09:12:40
|
Patches item #2014467, was opened at 2008-07-09 20:13 Message generated for change (Comment added) made by keithmarshall You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Keith Marshall (keithmarshall) Date: 2008-07-28 09:12 Message: Logged In: YES user_id=823908 Originator: NO > ... would something like the following be suitable? > > Added header declarations and changes to .def files for some missing > kernel APIs, as needed for Xen win-pvdrivers compilation. Just that? Sorry, but absolutely not; it is much too vague! ChangeLog entries should follow the GNU Coding Standard: http://www.gnu.org/prep/standards/html_node/Change-Logs.html What you have proposed will suffice for a summary line, (which some consider optional, but I personally like to see; I also use it as the log message for the CVS commit). However, you must also provide a full list, itemised by file, of every symbol or function you have added, modified or removed. Please ensure that *every* symbol or function name is spelled out in full; wildcards are not acceptable. Also, when you submit multiple patches, each should be accompanied by its own ChangeLog, (as a separate entity please, *not* as a diff against the existing ChangeLog, although it may be included as non-diff preamble, within a diff file); the accepting authority can then fold this into the existing ChangeLog, in the appropriate position, at the time of committal. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-28 02:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 22:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-26 01:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-11 00:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 23:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 20:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 12:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 01:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 23:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-07-29 05:03:54
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-07-28 22:03 Message: Logged In: YES user_id=122770 Originator: YES ok I'll do them :) give me a day or two, eh? ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-07-28 02:12 Message: Logged In: YES user_id=823908 Originator: NO > ... would something like the following be suitable? > > Added header declarations and changes to .def files for some missing > kernel APIs, as needed for Xen win-pvdrivers compilation. Just that? Sorry, but absolutely not; it is much too vague! ChangeLog entries should follow the GNU Coding Standard: http://www.gnu.org/prep/standards/html_node/Change-Logs.html What you have proposed will suffice for a summary line, (which some consider optional, but I personally like to see; I also use it as the log message for the CVS commit). However, you must also provide a full list, itemised by file, of every symbol or function you have added, modified or removed. Please ensure that *every* symbol or function name is spelled out in full; wildcards are not acceptable. Also, when you submit multiple patches, each should be accompanied by its own ChangeLog, (as a separate entity please, *not* as a diff against the existing ChangeLog, although it may be included as non-diff preamble, within a diff file); the accepting authority can then fold this into the existing ChangeLog, in the appropriate position, at the time of committal. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-27 19:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 15:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 18:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 17:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 16:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 13:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 05:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-08-27 12:08:26
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-08-27 08:08 Message: Logged In: YES user_id=570619 Originator: NO I plan on rolling out a new w32api this weekend, please supply an updated patch including a ChangeLog by August 29th if these changes are to be included in the next release. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-29 01:03 Message: Logged In: YES user_id=122770 Originator: YES ok I'll do them :) give me a day or two, eh? ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-07-28 05:12 Message: Logged In: YES user_id=823908 Originator: NO > ... would something like the following be suitable? > > Added header declarations and changes to .def files for some missing > kernel APIs, as needed for Xen win-pvdrivers compilation. Just that? Sorry, but absolutely not; it is much too vague! ChangeLog entries should follow the GNU Coding Standard: http://www.gnu.org/prep/standards/html_node/Change-Logs.html What you have proposed will suffice for a summary line, (which some consider optional, but I personally like to see; I also use it as the log message for the CVS commit). However, you must also provide a full list, itemised by file, of every symbol or function you have added, modified or removed. Please ensure that *every* symbol or function name is spelled out in full; wildcards are not acceptable. Also, when you submit multiple patches, each should be accompanied by its own ChangeLog, (as a separate entity please, *not* as a diff against the existing ChangeLog, although it may be included as non-diff preamble, within a diff file); the accepting authority can then fold this into the existing ChangeLog, in the appropriate position, at the time of committal. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-27 22:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 18:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 21:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 20:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 19:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 16:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-08-28 21:42:31
|
Patches item #2014467, was opened at 2008-07-09 13:13 Message generated for change (Comment added) made by agrover You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- >Comment By: Andy Grover (agrover) Date: 2008-08-28 14:42 Message: Logged In: YES user_id=122770 Originator: YES File Added: changelog1.txt ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-08-27 05:08 Message: Logged In: YES user_id=570619 Originator: NO I plan on rolling out a new w32api this weekend, please supply an updated patch including a ChangeLog by August 29th if these changes are to be included in the next release. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-28 22:03 Message: Logged In: YES user_id=122770 Originator: YES ok I'll do them :) give me a day or two, eh? ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-07-28 02:12 Message: Logged In: YES user_id=823908 Originator: NO > ... would something like the following be suitable? > > Added header declarations and changes to .def files for some missing > kernel APIs, as needed for Xen win-pvdrivers compilation. Just that? Sorry, but absolutely not; it is much too vague! ChangeLog entries should follow the GNU Coding Standard: http://www.gnu.org/prep/standards/html_node/Change-Logs.html What you have proposed will suffice for a summary line, (which some consider optional, but I personally like to see; I also use it as the log message for the CVS commit). However, you must also provide a full list, itemised by file, of every symbol or function you have added, modified or removed. Please ensure that *every* symbol or function name is spelled out in full; wildcards are not acceptable. Also, when you submit multiple patches, each should be accompanied by its own ChangeLog, (as a separate entity please, *not* as a diff against the existing ChangeLog, although it may be included as non-diff preamble, within a diff file); the accepting authority can then fold this into the existing ChangeLog, in the appropriate position, at the time of committal. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-27 19:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 15:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 18:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 17:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 16:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 13:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 05:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 18:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 16:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |
From: SourceForge.net <no...@so...> - 2008-08-29 11:03:39
|
Patches item #2014467, was opened at 2008-07-09 16:13 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Andy Grover (agrover) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: w32api: winddk.h and ntoskrnl.def fixes (1/5) Initial Comment: I am working on porting 3 drivers to mingw. If you're interested, the hg repo for the work is available at http://xenbits.xensource.com/ext/win-pvdrivers.hg . Basically it's disk and net paravirtualization drivers for Xen. Its main components are a net driver, disk driver, and pci bus driver/enumerator. This first patch adds needed exports to winddk.h and ntoskrnl.def for us (KeNumberProcessors and KeFlushQueuedDpcs()), fixes an incorrect #define, defines KeMemoryBarrier, and fixes warnings coming from InterlockedIncrement and Decrement(). ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-08-29 07:03 Message: Logged In: YES user_id=570619 Originator: NO Your patch has been accepted and is now commited to CVS. You should expect to see it in the next release. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-08-28 17:42 Message: Logged In: YES user_id=122770 Originator: YES File Added: changelog1.txt ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-08-27 08:08 Message: Logged In: YES user_id=570619 Originator: NO I plan on rolling out a new w32api this weekend, please supply an updated patch including a ChangeLog by August 29th if these changes are to be included in the next release. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-29 01:03 Message: Logged In: YES user_id=122770 Originator: YES ok I'll do them :) give me a day or two, eh? ---------------------------------------------------------------------- Comment By: Keith Marshall (keithmarshall) Date: 2008-07-28 05:12 Message: Logged In: YES user_id=823908 Originator: NO > ... would something like the following be suitable? > > Added header declarations and changes to .def files for some missing > kernel APIs, as needed for Xen win-pvdrivers compilation. Just that? Sorry, but absolutely not; it is much too vague! ChangeLog entries should follow the GNU Coding Standard: http://www.gnu.org/prep/standards/html_node/Change-Logs.html What you have proposed will suffice for a summary line, (which some consider optional, but I personally like to see; I also use it as the log message for the CVS commit). However, you must also provide a full list, itemised by file, of every symbol or function you have added, modified or removed. Please ensure that *every* symbol or function name is spelled out in full; wildcards are not acceptable. Also, when you submit multiple patches, each should be accompanied by its own ChangeLog, (as a separate entity please, *not* as a diff against the existing ChangeLog, although it may be included as non-diff preamble, within a diff file); the accepting authority can then fold this into the existing ChangeLog, in the appropriate position, at the time of committal. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-27 22:32 Message: Logged In: YES user_id=570619 Originator: NO Samples of typical w32api ChangeLog entries can be found here: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/ChangeLog?rev=1.955&content-type=text/x-cvsweb-markup&cvsroot=src ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-27 18:29 Message: Logged In: YES user_id=122770 Originator: YES No... Please correct for your preferred changelog format, but would something like the following be suitable? Added header declarations and changes to .def files for some missing kernel APIs, as needed for Xen win-pvdrivers compilation. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-25 21:56 Message: Logged In: YES user_id=570619 Originator: NO Is there a ChangeLog entry in one of the 5 patches? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 20:13 Message: Logged In: YES user_id=122770 Originator: YES OK thanks. Like I said, current patches have code in question removed, so they're good. If I'm able to find the missing stuff on the web in the future I'll submit it separately. Thanks -- Andy ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 19:40 Message: Logged In: YES user_id=15438 Originator: NO <quote>But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear?</quote> No, it has to be publicly available documentation written in such a manner. No one associated with the development of MinGW can be the technical writer w.r.t. this purpose or I would have begun it years ago. In reality the technical writer and the developer cannot even communicate with one another. ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-10 16:42 Message: Logged In: YES user_id=122770 Originator: YES I've uploaded a new version of patch 4 that does not include the defines/enum in question. I can find the defines on the web, but can't find the enum anywhere. But are you saying if I get a coworker to look at the sdk header and email me an english-text description of what the two enum values are, then we'd be in the clear? ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2008-07-10 08:32 Message: Logged In: YES user_id=15438 Originator: NO We do not share the React-OS view of "viewing proprietary source code for educational purposes." You can review the mingw-dvlpr and mingw-users archives for more discussion in this area. If the information isn't publicly available then we become suspect for copyright infringement. I would love for some technical writer that isn't involved with any other project to create a project to document in English sentence structure all of the API, giving the values for the constants. That said can you find anything on the web that isn't in a SDK header that gives you the values of the constants, enums and the like? ---------------------------------------------------------------------- Comment By: Andy Grover (agrover) Date: 2008-07-09 21:13 Message: Logged In: YES user_id=122770 Originator: YES Everything is derived from msdn with the exception of some #define/enum values which are needed for interoperability. I referred to http://www.reactos.org/en/dev_legalreview.html section II.C. is that also applicable to w32api? Both instances are in patch 4, the enum _NDIS_DEVICE_PNP_EVENT entries and the 5 tcp offload OIDs. These are the only bits I have any doubts about, so please let me know if your inclusion policy is different from Reactos's and I can respin the patch without them, and follow your directions on how to obtain them by a method within your guidelines. ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2008-07-09 19:35 Message: Logged In: YES user_id=570619 Originator: NO I assume all of these 5 patches are generated from publicly available sources? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2014467&group_id=2435 |