[Mingw-notify] [ mingw-Bugs-1759317 ] Command Line dropped

[SourceForge.net <noreply@so...>]

Bugs item #1759317, was opened at 2007-07-24 00:26
Message generated for change (Comment added) made by cstrauss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1759317&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: msys
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alexis Wilke (alexis_wilke)
Assigned to: Cesar Strauss (cstrauss)
Summary: Command Line dropped

Initial Comment:
There has been a very annoying bug in the latest MSYS (and oldest ones too) and thus, I lastly decided to look into it to see exactly what happens.

The problem is: at times, some tools just don't get their command line arguments (see https://sourceforge.net/tracker/index.php?func=detail&aid=1043939&group_id=2435&atid=102435 which is the same bug with gcc/g++)

First I thought it would be in bash. So I decided to look into bash and was very surprised to see that the CVS actually included bash 3.1 but no binary for download! I thus recompiled 3.2 after I carefully applied the changes found in 3.1 (in which I found 2 bugs, interested?.) Then I tried to run the failing command. Same thing. The arguments are NOT passed in. (I check with argc/argv and GetCommandLine() and I only get the name of the app.)

Inside bash, there is one call to execve(). I put a loop there with fprintf() to print all the arguments. There are all there. Thus bash does it right (I was thinking that since there are some changes, maybe it would fail there...)

So... the only place where the problem can arise is the implementation of execve() in MSYS. Now I hit another wall... I could not get anything to compile under the rt directory. Do I need to compile all of that under Linux? Or can it be compiled from within an existing msysDTK? It feels like the msysDTK may miss a few things, but it could be my install which is missing tons of stuff.

At this time, I will try to replicate the execve() in bash which anyway would be a lot easier. I suspect that the problem is the CreateProcess() first argument. It should be NULL. Don't ask me why. In general it works, often it just does not. Microsoft magical mysteries... I had problems before in my own code with that instruction unless I put NULL in the first argument.

This would solved a bug which you have had around for ages!

If you have a place with good and thorough instructions to compile the rt (because I did not see that in that directory docs... or am I blind?!)

Thank you for your support,
Alexis


----------------------------------------------------------------------

>Comment By: Cesar Strauss (cstrauss)
Date: 2007-07-25 19:52

Message:
Logged In: YES 
user_id=1369729
Originator: NO

Hi, Alexis

> The problem is: at times, some tools just don't get
> their command line arguments

Did you, by any chance, place your test program in the /bin or /usr/bin
directory? Note that you should not do that (see the last paragraph on
doc/msys/MSYS_WELCOME.rtf). The CVS version, which will become the 1.0.11
version, doesn't have this restriction anymore.

In any case, could you please paste the output of "uname -a"?

> I check with argc/argv and GetCommandLine()

Could you attach the source code for this test program and the command
line used to compile it? I would like to check it myself.

> I could not get anything to compile under the rt directory

The following wiki page has instructions for building MSYS:

http://www.mingw.org/MinGWiki/index.php/Build%20MSYS

Please use the CVS version, and do not forget to create a build directory
separated from the source directory.

Regards,
Cesar


----------------------------------------------------------------------

Comment By: Alexis Wilke (alexis_wilke)
Date: 2007-07-25 03:39

Message:
Logged In: YES 
user_id=554061
Originator: YES

Okay... Well...

I tried to just put a NULL, but the command line can be NULL as well when
executing a "cygwin" (that is, MSYS here) executable. So I will have to
recompile to test a full fix. (I just tweaked the binary so far which did
not take me very long, changed 1 byte. But in case of an MSYS exec. it
crashes because both parameters are NULL)

Let me know if you find anything on your end.

Thank you,
Alexis

----------------------------------------------------------------------

Comment By: Alexis Wilke (alexis_wilke)
Date: 2007-07-24 03:33

Message:
Logged In: YES 
user_id=554061
Originator: YES

Okay, there is the reason: in some cases, somehow, you add quotes to the
1st argument of the command line but not to the "real path". When that
happens the name of the executable in the 1st parameter to CreateProcess()
!= real-path. Newer versions of MS-Windows test that and ignore the command
line (it seems at least to me that this is what happens...)

I looked into getting that execve() in bash but that's going way to deep
(with stuff from mount.cc, path.cc, process stuff, myself global, etc. etc.
etc.)

So, I'll try to cross compile. If that works, I will be able to post a fix
soon...

If you have comments, I'd appreciate to get your input.

Thank you,
Alexis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1759317&group_id=2435

[Mingw-notify] [ mingw-Bugs-1759317 ] Command Line dropped

[SourceForge.net <noreply@so...>]

Bugs item #1759317, was opened at 2007-07-23 20:26
Message generated for change (Comment added) made by alexis_wilke
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1759317&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: msys
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alexis Wilke (alexis_wilke)
Assigned to: Cesar Strauss (cstrauss)
Summary: Command Line dropped

Initial Comment:
There has been a very annoying bug in the latest MSYS (and oldest ones too) and thus, I lastly decided to look into it to see exactly what happens.

The problem is: at times, some tools just don't get their command line arguments (see https://sourceforge.net/tracker/index.php?func=detail&aid=1043939&group_id=2435&atid=102435 which is the same bug with gcc/g++)

First I thought it would be in bash. So I decided to look into bash and was very surprised to see that the CVS actually included bash 3.1 but no binary for download! I thus recompiled 3.2 after I carefully applied the changes found in 3.1 (in which I found 2 bugs, interested?.) Then I tried to run the failing command. Same thing. The arguments are NOT passed in. (I check with argc/argv and GetCommandLine() and I only get the name of the app.)

Inside bash, there is one call to execve(). I put a loop there with fprintf() to print all the arguments. There are all there. Thus bash does it right (I was thinking that since there are some changes, maybe it would fail there...)

So... the only place where the problem can arise is the implementation of execve() in MSYS. Now I hit another wall... I could not get anything to compile under the rt directory. Do I need to compile all of that under Linux? Or can it be compiled from within an existing msysDTK? It feels like the msysDTK may miss a few things, but it could be my install which is missing tons of stuff.

At this time, I will try to replicate the execve() in bash which anyway would be a lot easier. I suspect that the problem is the CreateProcess() first argument. It should be NULL. Don't ask me why. In general it works, often it just does not. Microsoft magical mysteries... I had problems before in my own code with that instruction unless I put NULL in the first argument.

This would solved a bug which you have had around for ages!

If you have a place with good and thorough instructions to compile the rt (because I did not see that in that directory docs... or am I blind?!)

Thank you for your support,
Alexis


----------------------------------------------------------------------

>Comment By: Alexis Wilke (alexis_wilke)
Date: 2007-07-24 23:39

Message:
Logged In: YES 
user_id=554061
Originator: YES

Okay... Well...

I tried to just put a NULL, but the command line can be NULL as well when
executing a "cygwin" (that is, MSYS here) executable. So I will have to
recompile to test a full fix. (I just tweaked the binary so far which did
not take me very long, changed 1 byte. But in case of an MSYS exec. it
crashes because both parameters are NULL)

Let me know if you find anything on your end.

Thank you,
Alexis

----------------------------------------------------------------------

Comment By: Alexis Wilke (alexis_wilke)
Date: 2007-07-23 23:33

Message:
Logged In: YES 
user_id=554061
Originator: YES

Okay, there is the reason: in some cases, somehow, you add quotes to the
1st argument of the command line but not to the "real path". When that
happens the name of the executable in the 1st parameter to CreateProcess()
!= real-path. Newer versions of MS-Windows test that and ignore the command
line (it seems at least to me that this is what happens...)

I looked into getting that execve() in bash but that's going way to deep
(with stuff from mount.cc, path.cc, process stuff, myself global, etc. etc.
etc.)

So, I'll try to cross compile. If that works, I will be able to post a fix
soon...

If you have comments, I'd appreciate to get your input.

Thank you,
Alexis

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102435&aid=1759317&group_id=2435