[MinGW-notify] [ mingw-Patches-3237456 ] INCLUDES in lib/*/Makefile.in

[SF/projects/mingw n. l. <min...@li...>]

Patches item #3237456, was opened at 2011-03-23 13:46
Message generated for change (Tracker Item Submitted) made by antoinel
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=3237456&group_id=2435

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: w32api
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Antoine LECA (antoinel)
Assigned to: Nobody/Anonymous (nobody)
Summary: INCLUDES in lib/*/Makefile.in

Initial Comment:
In .../winsup/w32api/lib/Makefile.in, the INCLUDES variable is initialized with
  ifeq ($(BUILDENV), cygwin)
  EXTRA_INCLUDES = -I$(srcdir)/../../include -I$(srcdir)/../../../newlib/libc/include -I$(srcdir)/../../../newlib/libc/sys/cygwin
  endif
  ifeq ($(BUILDENV), mingw)
  EXTRA_INCLUDES = -I$(srcdir)/../../mingw/include
  endif
  INCLUDES = -I$(srcdir)/../include $(EXTRA_INCLUDES)
As a result, the last line crops the w32api/include directory. Fine so far

In .../winsup/w32api/lib/{ddk,directx}/Makefile.in, that is, one level deeper, the INCLUDES variable is initialized with

  ifeq ($(BUILDENV), cygwin)
  EXTRA_INCLUDES = -I$(srcdir)/../../include -I$(srcdir)/../../../newlib/libc/include -I$(srcdir)/../../../newlib/libc/sys/cygwin
  endif
  ifeq ($(BUILDENV), mingw)
  EXTRA_INCLUDES = -I$(srcdir)/../../mingw/include
  endif

  INCLUDES = -I$(srcdir)/../include -I$(srcdir)/../include/directx $(EXTRA_INCLUDES)

If I am not mistaken, the last line has no effect (there are no w32api/lib/include/* subdir), and only when the BUILDENV variable is set to Cygwin will the w32api/include directory be searched, more by chance than anything else.
Also it is possible that many people do not notice the problem since they are compiling with an already working environment, with the needed headers in the standard place.

I guess the $(srcdir)/../ should be changed to $(srcdir)/../../ in the deeper Makefile.in

Please note the HEADERS variable a few lines below is correctly initialized

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=302435&aid=3237456&group_id=2435