Re: [Mingw-users] TMT_TEXTSHADOWCOLOR wrongly defined

[Earnie B. <ea...@us...>]

Quoting Michael Gerdau <mg...@te...>:

>> > Looking into uxtheme.h it appears as if a whole block of constants
>> > had been defined to the wrong values by means of a typo. Se below
>> > the constants involved and what they should be.
>>
>> Looking at the headers supplied by MS isn't correct.  We will need
>> documentation references to accept any patch.
>
> Nowhere in the mail of the OP nor in my mail were MS supplied headers
> mentioned. I for that didn't look into MS supplied headers but looked
> at the w32api supplied header. As I wrote in my last mail, the
> definition of a couple of headers is obviously (at leat I think it is
> obvious) off by 1, presumably due to a cut-n-paste error when originally
> creating them. Or does anybody believe TMT_GRADIENTCOLOR3 and
> TMT_GRADIENTCOLOR4 had been defined to the same constant deliberately ?
>
> I also searched the wine headers, specifically tmschema.h and there
> I found the same constant defined to the value the OP claimed.
>

The WINE headers are also off limits unless the header is stated to be 
in public domain (i.e. no copyright).  AFAIK the WINE source has a 
copyright and licensed with the GPL.


> AFAIC this was an _additional_ indication as to the bug in uxtheme.h
> but IMO realizing TMT_GRADIENTCOLOR3 and TMT_GRADIENTCOLOR4 are
> defined equal would have been sufficient in it's own right.
>
> Let me reiterate:
> No MS supplied headers were knowingly involved in creating this patch.
>

Ok, thanks, the statements appeared to be implying that other source 
files were being used.  I will consult the other developers on the 
developers list.

Earnie Boyd

http://shop.siebunlimited.com