#2084 Missing macros in wincrypt.h

WSL
open
None
Feature
accepted
Feature_in_WSL_4.1
True
2013-10-09
2013-10-05
No

wincrypt.h is missing some macros.
Microsoft has openly documented them in these pages:

http://msdn.microsoft.com/en-us/library/windows/desktop/aa376078%28v=vs.85%29.aspx

CERT_CHAIN_CACHE_END_CERT
CERT_CHAIN_REVOCATION_CHECK_CACHE_ONLY
CERT_CHAIN_REVOCATION_CHECK_OCSP_CERT
CERT_CHAIN_CACHE_ONLY_URL_RETRIEVAL
CERT_CHAIN_DISABLE_PASS1_QUALITY_FILTERING
CERT_CHAIN_DISABLE_MY_PEER_TRUST
CERT_CHAIN_ENABLE_PEER_TRUST
CERT_CHAIN_RETURN_LOWER_QUALITY_CONTEXTS
CERT_CHAIN_DISABLE_AUTH_ROOT_AUTO_UPDATE
CERT_CHAIN_REVOCATION_ACCUMULATIVE_TIMEOUT
CERT_CHAIN_TIMESTAMP_TIME
CERT_CHAIN_REVOCATION_CHECK_END_CERT
CERT_CHAIN_REVOCATION_CHECK_CHAIN
CERT_CHAIN_REVOCATION_CHECK_CHAIN_EXCLUDE_ROOT

http://msdn.microsoft.com/en-us/library/windows/desktop/aa377184%28v=vs.85%29.aspx

CERT_CHAIN_CACHE_ONLY_URL_RETRIEVAL
CERT_CHAIN_USE_LOCAL_MACHINE_STORE
CERT_CHAIN_ENABLE_CACHE_AUTO_UPDATE
CERT_CHAIN_ENABLE_SHARE_STORE
CERT_CHAIN_EXCLUSIVE_ENABLE_CA_FLAG

Many of these macros are required for compiling SVN with wincrypt support so, if it's possible, it would be worth to add them.

Discussion

  • Earnie Boyd

    Earnie Boyd - 2013-10-05
    • labels: --> 4.1 if patch supplied else 5.0
    • status: unread --> assigned
    • assigned_to: Earnie Boyd
    • Type: Bug --> Feature
    • Resolution: none --> later
    • Category: Feature_in_WSL_4.1 --> WSL-5.0-feature
     
  • Earnie Boyd

    Earnie Boyd - 2013-10-05

    If someone clones mingw-org-wsl and supplies a patch against the 4.1-dev branch I'll accept it for the 4.1 release. If it waits on me it will be 5.0 before I get it done.

     
  • Carlo Bramini

    Carlo Bramini - 2013-10-05

    I cloned the sources and I'm supplying a patch as you requested.

     
    • Earnie Boyd

      Earnie Boyd - 2013-10-05

      Certain of these flags were added for Vista and above. For example CERT_CHAIN_ENABLE_PEER_TRUST states "Windows Server 2003 and Windows XP: This flag is not supported." on the page you linked to. This means that those defines need to go in the filtered section for _WIN32_WINNT >= _WIN32_WINNT_VISTA or another appropriate filter.

       
  • Earnie Boyd

    Earnie Boyd - 2013-10-06
    • labels: 4.1 if patch supplied else 5.0 --> 4.1 if patch supplied else 5.0, needs work
    • Patch attached: False --> True
     
  • Carlo Bramini

    Carlo Bramini - 2013-10-08

    I updated the patch according to your request.

     
    • Earnie Boyd

      Earnie Boyd - 2013-10-08

      That is close but I want to keep the filtered OS sections in their own group rather than scattered throughout the file. So the Vista stuff needs to go in the VISTA filter that is already present near the end of the file and the WIN8 stuff needs a new filter after the VISTA one.

      Also, name the file with a .patch extension for my benefit and thanks for stepping up to supply the patch.

       
      • Earnie Boyd

        Earnie Boyd - 2013-10-08

        And add a ChangeLog entry.

         
  • Carlo Bramini

    Carlo Bramini - 2013-10-08

    I updated again the patch.
    Thank you for your patience!

     
  • Earnie Boyd

    Earnie Boyd - 2013-10-09
    • labels: 4.1 if patch supplied else 5.0, needs work -->
    • status: assigned --> open
    • Resolution: later --> accepted
    • Category: WSL-5.0-feature --> Feature_in_WSL_4.1
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks