Hi Ray,

It looks good to me now.

Thanks,
Jacek

On 02/13/13 00:30, Ray Donnelly wrote:
Hi Jacek,

I hope this is ok now?

Best regards,

Ray.

On Mon, Feb 11, 2013 at 12:27 PM, Ray Donnelly <mingw.android@gmail.com> wrote:
I think I took it as an opportunity to learn a tiny bit of automake
having avoided it so far!

Ho hum... an update is in progress.

On Mon, Feb 11, 2013 at 10:58 AM, Jacek Caban <jacek@codeweavers.com> wrote:
Hi Ray,

Sorry for my response time too... Why don't you put the warning in
configure.ac instead of Makefile? Also the warning could say something like
"--with-widl used in out of the tree compilation. Existing generated files
won't be modified."

Cheers,
Jacek


On 02/03/13 19:44, Ray Donnelly wrote:

Hi Jacek,

Sorry for the long response time.

Please find attached a new version of the patch that adds the warning
you mentioned.

I also named it as .a txt file and removed all auto generated files.

Best regards,

Ray.

On Mon, Jan 14, 2013 at 12:40 PM, Jacek Caban <jacek@codeweavers.com> wrote:

Hi Ray,

.idl.h: crt/_mingw.h
-       $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include
-I$(srcdir)/direct-x/include -Icrt -I$(srcdir)/crt -h -o $(srcdir)/$@ $<
+       $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include
-I$(srcdir)/direct-x/include -Icrt -I$(srcdir)/crt -h -o $@ $<


The current code is indeed a hack, but it's intentional. Compiling with
--with-widl is a maintainer-like mode and is supposed to change files in
source directories.

That said, --with-widl works best if ran in config where
srcdir=builddir, because widl-generated comments look better then. We
could change the way it works like you propose (so that if someone
really wants widl-maintainer more, he is expected to build from srcdir),
but for that I think we'd need a warning in configure when someone uses
--with-widl and srcdir!=builddir.

Thanks,
Jacek

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan



_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb


_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public