Hi,
I've been working with the current CVS code for metadot, and have fixed a few things.
1) mysql_insertid wasn't working. This is probably a bug in our specific version of DBI/DBD/MySQL, but this fixes it, and shouldn't break anything else:
% diff DBAccess.pm.orig DBAccess.pm 168c168,171 < if(!$dbh->do($sql)) { --- > my ($cursor) = $dbh->prepare($sql); > if ($cursor && $cursor->execute) { > return $cursor->{'mysql_insertid'}; > } else { 173,174d175 < } else { < return $dbh->{'mysql_insertid'};
2) stripBadHTML called incorrectly:
% diff MyPage.pm.orig MyPage.pm 1036c1036 < my $name = Verify->stripBadHTML($FORM{$vname}) || ""; --- > my $name = Verify::stripBadHTML($FORM{$vname}) || ""; 1038c1038 < my $url = Verify->stripBadHTML($FORM{$vurl}) || ""; --- > my $url = Verify::stripBadHTML($FORM{$vurl}) || "";
3) grpmembers misspelled:
% diff Group.pm.orig Group.pm 779c779 < unless (DBAccess->sqlSelect("uid", "grpmemebers", "uid = $uid AND $grp_id = grp_id")) { --- > unless (DBAccess->sqlSelect("uid", "grpmembers", "uid = $uid AND $grp_id = grp_id")) {
4) missing '>' in html in Channel.pm and Gizmo.pm
% diff Channel.pm.orig Channel.pm 195c195 < "<table align=right><tr><td><input type='submit' value='Create'</td></tr></table> --- > "<table align=right><tr><td><input type='submit' value='Create'></td></tr></table> 221c221 < "<table align=right><tr><td><input type='submit' value='Create'</td></tr></table> --- > "<table align=right><tr><td><input type='submit' value='Create'></td></tr></table> 352c352 < "<table align=right><tr><td><input type='submit' value='Save'</td></tr></table> --- > "<table align=right><tr><td><input type='submit' value='Save'></td></tr></table> 386c386 < "<table align=right><tr><td><input type='submit' value='Save'</td></tr></table> --- > "<table align=right><tr><td><input type='submit' value='Save'></td></tr></table>
% diff Gizmo.pm.orig Gizmo.pm 765c765 < <table align=right><tr><td><input type='submit' value='Save'</td></tr></table> --- > <table align=right><tr><td><input type='submit' value='Save'></td></tr></table> 768c768 < <table align=right><tr><td><input type='submit' value='Save'</td></tr></table> --- > <table align=right><tr><td><input type='submit' value='Save'></td></tr></table>
Log in to post a comment.
Hi,
I've been working with the current CVS code for metadot, and have fixed a few
things.
1) mysql_insertid wasn't working. This is probably a bug in our specific version
of DBI/DBD/MySQL, but this fixes it, and shouldn't break anything else:
% diff DBAccess.pm.orig DBAccess.pm
168c168,171
< if(!$dbh->do($sql)) {
---
> my ($cursor) = $dbh->prepare($sql);
> if ($cursor && $cursor->execute) {
> return $cursor->{'mysql_insertid'};
> } else {
173,174d175
< } else {
< return $dbh->{'mysql_insertid'};
2) stripBadHTML called incorrectly:
% diff MyPage.pm.orig MyPage.pm
1036c1036
< my $name = Verify->stripBadHTML($FORM{$vname}) || "";
---
> my $name = Verify::stripBadHTML($FORM{$vname}) || "";
1038c1038
< my $url = Verify->stripBadHTML($FORM{$vurl}) || "";
---
> my $url = Verify::stripBadHTML($FORM{$vurl}) || "";
3) grpmembers misspelled:
% diff Group.pm.orig Group.pm
779c779
< unless (DBAccess->sqlSelect("uid", "grpmemebers", "uid = $uid AND $grp_id = grp_id")) {
---
> unless (DBAccess->sqlSelect("uid", "grpmembers", "uid = $uid AND $grp_id = grp_id")) {
4) missing '>' in html in Channel.pm and Gizmo.pm
% diff Channel.pm.orig Channel.pm
195c195
< "<table align=right><tr><td><input type='submit' value='Create'</td></tr></table>
---
> "<table align=right><tr><td><input type='submit' value='Create'></td></tr></table>
221c221
< "<table align=right><tr><td><input type='submit' value='Create'</td></tr></table>
---
> "<table align=right><tr><td><input type='submit' value='Create'></td></tr></table>
352c352
< "<table align=right><tr><td><input type='submit' value='Save'</td></tr></table>
---
> "<table align=right><tr><td><input type='submit' value='Save'></td></tr></table>
386c386
< "<table align=right><tr><td><input type='submit' value='Save'</td></tr></table>
---
> "<table align=right><tr><td><input type='submit' value='Save'></td></tr></table>
% diff Gizmo.pm.orig Gizmo.pm
765c765
< <table align=right><tr><td><input type='submit' value='Save'</td></tr></table>
---
> <table align=right><tr><td><input type='submit' value='Save'></td></tr></table>
768c768
< <table align=right><tr><td><input type='submit' value='Save'</td></tr></table>
---
> <table align=right><tr><td><input type='submit' value='Save'></td></tr></table>