|
From: Oscar B. <Osc...@Tu...> - 2008-10-15 09:32:21
|
Hello again, I had a question about the Decompose function in matrix44.h As i mentioned before (see below) i cant use this function for floats with out getting an assert on all the things that look like this: assert(math::Abs(R[1]*R[0])<1e-10); if i change to e-6 it works. I think it has something to do on the precision of floats on my computer. I use ubuntu linux with the gcc compiler. In any case, i dont understand exactly what they are checking but i seem to get the right results even with e-6. Is there some reason for these asserts that means we cant change them to e-6? Thanks, Oscar -----Original Message----- From: fabio ganovelli [mailto:fab...@gm...] Sent: Mon 9/22/2008 3:53 PM To: Meshlab development list Subject: Re: [Meshlab-devel] found 3 bugs in VCG Hi, the bugs you have found have been now corrected, thank you. It's ok to post on this list since most of the vcg users are meshlab users. cheers, Fabio > Hello all, > > Right now Meshlab will not build with the current svn version of vcg > (2899) > > ----Bug 1---------------- > > In the file vcg/space/point.h > > PointBase() > :Point<D,S>() > > This D should be an N on line 972. > > ----Bug 2------------------ > > In the file vcg/math/camera.h > > Camera<S>:: needs to be deleted from line 218 shown here: > > inline vcg::Point2<S> Camera<S>::ViewportPxTo_neg1_1(const > vcg::Point2<S> & p) const; > > Please remember to do a clean and build sometimes to make sure there are > no problems. These bugs have been here for almost two weeks now. > > > ------Bug 3-------- > This is not a critical bug that keeps anything from compiling but i > thought i would mention it anyway. > > In the file vcg/math/matrix44.h > > in the Decompose function Point3d R[3]; should be Point3<T> > R[3]; so it can work with other types like float. > > Just another note about this. When i tried to use floats all the > asserts failed that check against 1e-10. I changed this to e-7 and it > seems to work. On my machine maybe float operations are not accurate > out to 10 decimal places? > > I would be happy to commit all these fixes but i dont have access to > vcg. should i have sent this to a vcg mail list also? > > Thanks, > > Oscar > > > ------------------------------------------------------------------------ - > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Meshlab-devel mailing list > Mes...@li... > https://lists.sourceforge.net/lists/listinfo/meshlab-devel > > ------------------------------------------------------------------------ - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Meshlab-devel mailing list Mes...@li... https://lists.sourceforge.net/lists/listinfo/meshlab-devel |
