|
From: Francesco T. <lit...@gm...> - 2008-07-23 15:49:55
|
Hi Paolo, I'm going to commit the feature that you request me today, about white balance. Get a look, it seems to work fine. Doing that work I saw that, in some cases, the code could encounter a division by zero, for example when the color used to correct the white has a component to 0... I try some of this cases and the app does't crashes (strange, it should...) but I thing the result is anyway incorrect. How do you want that I fix this bug? replacing zeros with 1? is it wise? I think so, because a component less then 1 leads to a correction factor greater then 255, and it will be clamped anyway... let me know your strategy and I'll modify soon. comments to the code will be provided asap. cheers. |
