Fix incorrect rendering (patch included)

Status: Beta

Brought to you by: hessint

#5 Fix incorrect rendering (patch included)

Status: open

Owner: nobody

Labels: Incorrect Heightmap (1)

Priority: 5

Updated: 2009-05-13

Created: 2009-05-13

Creator: Michael Buesch

Private: No

The attached patch fixes a rendering bug that results in the attached shapes-broken.pgm image. The expected image is attached as shapes.pgm.
The patch replaces a comparison ((float)x == 0.0) by (fabs(x) < very_small_fp_value).
Due to floating point not being exact, it depends on the FP format and the CPU whether a direct comparison will be true or not.
The ==0.0 test breaks on PowerPC and X86_64.

Discussion

Michael Buesch - 2009-05-13

Patch

004-fix-clipping.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michael Buesch - 2009-05-13

Broken result (Patch not applied)

shapes-broken.pgm

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michael Buesch - 2009-05-13

Expected result (Patch applied)

shapes.pgm

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fix incorrect rendering (patch included)

Group

Searches

Help

#5 Fix incorrect rendering (patch included)

Discussion