Re: [Mesa3d-dev] color matrix manip bug

[Keith W. <ke...@va...>]

Stephane Conversy wrote:
> 
> Hi.
> 
> mesa 3.5, in matrix.c:78, when manipulating
> the color matrix, shouldn't flags be set to:
> 
> flags |= _NEW_COLOR_MATRIX | _NEW_PIXEL;
> 
> instead of:
> 
> flags |= _NEW_COLOR_MATRIX;
> 
> doing so fixes a bug when copying into a texture
> (ie mesa_update_state is called)...

It sounds like the opposite is true: there is a place where we are checking
for _NEW_PIXEL where we should (also?) be checking for _NEW_COLOR_MATRIX.  It
is the color matrix that is being changed at this point, so that is the bit
which is set.

Keith