[Mesa3d-dev] Mesa autoconf problem

[Brian P. <br...@va...>]

I'm trying to understand an autoconf problem and am looking for some
answers and/or advice.

Mesa bug 423843 is as follows:

                 When specified --enable-x86 in command line (in my 
                 case, on Am486 processor I doesn't want to build MMX 
                 support) I don't have compiling of any assembler source 
                 in src/X86. 

                 In configure script there are lines to check whether 
                 binutils support cpuid but where we check if have_x86 
                 variable has "on" value. 
                 But if I specify --enable-x86 in command line value 
                 have_x86 variable has "yes" of "no" value, not "on" or 
                 "off". 

                 Small workaround patch: 
                 *** configure.old Thu Feb 8 05:27:38 2001 
                 --- configure Mon May 14 11:27:51 2001 
                 *************** esac 
                 *** 2684,2689 **** 
                 --- 2684,2694 ---- 
                 if test "${enable_x86+set}" = set; then 
                 enableval="$enable_x86" 
                 have_x86=$enableval 
                 + if test "x$have_x86" = xyes; then 
                 + have_x86=on 
                 + else 
                 + have_x86=off 
                 + fi 
                 fi 

                 if test "x$have_x86" = xon; then 


The basic issue is this: should boolean configuration variables use
the values "yes/no" or "on/off"?  There doesn't seem to be any consistency
to this.

If --enable-x86 is specified to configure, $enable_x86 and $have_x86
are set to "yes".  But $have_x86 is tested for "on" in several places
in the configure script.  Something's wrong.

Is there any reason why "yes/no" shouldn't be used everywhere?

-Brian