Re: [Mesa3d-dev] X renderer speedup (write_span_mono_pixmap optimization)

[Jeff E. <je...@us...>]

> Jeff Epler wrote:
> > Would you like to incorporate the patch as-is, or incorporate modified
> > logic as Keith has suggested?
> 
Brian Paul wrote:
> Keith's looked a little cleaner.  Did you test it?

No, I didn't get a chance today.  I hope to test it tomorrow morning.
If it were my code, I'd have written a fencepost error in just to make
sure I had something to debug.

> > Another modification you might want before inclusion is a way to switch
> > back to the old per-pixel code when it's appropriate, such as when drawing
> > with a 50% stipple.  (The code as submitted draws this ~20% slower than
> > 3.4.1 in my test app, IIRC)
> 
> I might just #ifdef-out the old code but leave it there.  I think
> the Z buffer scenario you're using is more typical than the 50% stipple
> scenario.

I have the same suspicion, but wanted to include this information for
completeness.

Jeff
--