Re: [Mesa3d-dev] Re: [Mesa3d-cvs] CVS Update: Mesa (branch: trunk)

[Brian P. <br...@va...>]

Gareth Hughes wrote:
> 
> Gareth Hughes wrote:
> >
> > > With these latest changes it appears to me that the Format and Type
> > > fields in gl_texture_image are redundant with respect to the BaseFormat
> > > and BaseType fields in the gl_texture_format struct.  I'd like to
> > > remove Format and Type from the former and use the later instead.
> > > I'll work on that too.
> 
> Don't do this -- it's broken.  At the moment, when the hardware has to
> store GL_ALPHA textures in a GL_LUMINANCE_ALPHA format, for instance,
> texFormat->BaseFormat is incorrectly GL_LUMINANCE_ALPHA instead of
> GL_ALPHA.  This is obviously broken (try running texenv on the 3.5
> radeon driver).
> 
> I'm going to undo and rethink this change.


Yeah, I temporarily forgot about this problem too.  There's a difference
between the actual texture image storage 'format' and the 'format' used
during the texture environment computations.

-Brian