[Mesa3d-dev] Bug in subtexture_error_check()

[Gareth H. <ga...@va...>]

I'm running through the new Radeon texture state code and came across
this.  I've implemented full 1D and 2D texture image support (3D support
needs a bit more testing), and came across this:

   destTex = texUnit->CurrentD[2]->Image[level];
   if (!destTex) {
      gl_error(ctx, GL_INVALID_OPERATION, "glTexSubImage2D");
      return GL_TRUE;
   }

This seems to suggest that subtexture_error_check() will always fail if
the target is not GL_TEXTURE_2D.  Perhaps I'm the only one silly enough
to be looking at 1D and 3D subimage updates...

I'm changing the above to this:

   destTex = texUnit->Current->Image[level];

Are there any obvious hidden nasties in doing so?

-- Gareth