Re: [Mesa3d-dev] Lighting code in 3.5

[Keith W. <ke...@va...>]

Gareth Hughes wrote:
> 
> Keith, I haven't looked into this much yet, but I was wondering if you
> could give me a quick rundown of the changes you've made to
> t_shade_tmp.h -- I've noticed the masked versions have gone, as has the
> light->IsMatSpecular[side] test.
> 
> Thanks.  I'd like any work I do on replacements of the 3.4 code (for
> hardware drivers) to be easily transitioned to 3.5 when the time comes.
> 

The early culling code turned out to be a dead end in the face of assembly,
particularly 3dnow and I guess SSE, and cards that did fast culling at the end
of the pipe.  There ended up being less and less reason for it until you look
at the DRI drivers and they all turn it off.  I've removed it in 3.5.

The IsMatSpecular test I'm not so adamant about.  It can come back if anyone
feels strongly, but I felt it might be easier to get a clean assembly
implementation of lighting without it.

Anyway, there's another change to that file rattling through the pipes. 
Here's my latest code which cleans a few things up, and importantly removes
the requirement that VB->Flags exists (for DrawArrays this was a pain).

Keith