Re: [Mesa3d-dev] SET_IMMEDIATE macro in tnl/t_context.h

[Keith W. <ke...@va...>]

Li Ming wrote:
> 
> Hi,
> 
> Another compilation problem on Irix platform
> ----------symptom----------------
> cc-1133 cc: ERROR File = tnl/t_dlist.c, Line = 97
>   Expression must be a modifiable lvalue.
> 
>         SET_IMMEDIATE( ctx, new_im );
>         ^
> 
> cc-1133 cc: ERROR File = tnl/t_dlist.c, Line = 193
>   Expression must be a modifiable lvalue.
> 
>      SET_IMMEDIATE( ctx, TNL_VB(ctx)->IM );
>      ^
> 
> cc-1133 cc: ERROR File = tnl/t_dlist.c, Line = 204
>   Expression must be a modifiable lvalue.
> 
>      SET_IMMEDIATE( ctx, IM );
> 
> -----------cause-----------------
> This is because in tnl/t_context.h
>  do {                                            \
>      TNL_CURRENT_IM(ctx) = im;                    \
>      _mesa_CurrentInput = im;                     \
>  } while (0)
> 
> TNL_CURRENT_IM(ctx)  will produce a value not suitable put in the left
> side.
> 
> -----------solution----------------
> So maybe this line should be modified to
> ctx->swtnl_im = (void *)im
>

This makes sense, though I don't understand why it didn't complain to me (it
did about other similar problems).

Keith