Re: [Mesa3d-dev] Latest changes

[Brian P. <br...@va...>]

Keith Whitwell wrote:
> 
> Brian Paul wrote:
> >
> 
> >
> > How or where should we check for feedback and selection mode in
> > the point/line/triangle selection functions?  Should we test for
> > that down in the driver's code, or higher up in the _swrast_validate_point()
> > function?
> 
> Ahh..  I originally left the feedback/select point/line/tri functions up in
> the main directory.  In the last batch of changes I moved them down into
> swrast, but I forgot to update the _swrast_choose_line(), etc. functions. 
> The tests should be made there...
> 
> It'll be necessary to check the two drivers that extend swrast (x11, osmesa)
> to make sure that they respect rendermode in their chooser functions, too.


OK, I'm testing for feedback/selection in the XMesa driver now.
I had to tweak _swsetup_choose_rastersetup_func() as well.  As it
was, it was using a multi-texture setup function for selection/
feedback but the MULTITEX test in the setup function examines
the Texture._ReallyEnabled word.  In feedback mode, even if texture
is disabled you still have to return texture coords.
I'll check in my fix soon.

Selection mode with glPolygonMode(GL_POINT) isn't working yet.

-Brian