Re: [Mesa3d-users] Re: [Mesa3d-dev] Re: Mesa 3.2 for MS-VC, all the fixes

[Brian P. <br...@va...>]

Alessandro Pisani wrote:
> 
> At 19.30 12/07/00, you wrote:
> >Certainly the gl.h header has no business turning off warnings in application
> >programs!  Yikes!
> >
> >This needs to be included into a private Mesa header file.
> Please take a look to the resulting gl.h and the actual gl.h : the actual
> one does YET contains warning turns-off. Moreover, the resulting gl.h does
> not contains these turn-off AT ALL: I moved them in another file.
> So: look-BEFORE-say "Yikes!", please.
> 
> --- cut from GL.H of Mesa 3.2 OFFICIAL (not patched by me) ---
> #if !defined(OPENSTEP) && (defined(__WIN32__) || defined(__CYGWIN32__))
> #  pragma warning( disable : 4068 ) /* unknown pragma */
> #  pragma warning( disable : 4710 ) /* function 'foo' not inlined */
> #  pragma warning( disable : 4711 ) /* function 'foo' selected for
> automatic inline expansion */
> #  pragma warning( disable : 4127 ) /* conditional expression is constant */
> #       if defined(MESA_MINWARN)
> #         pragma warning( disable : 4244 ) /* '=' : conversion from 'const
> double ' to 'float ', possible loss of data */
> #         pragma warning( disable : 4018 ) /* '<' : signed/unsigned mismatch */
> #         pragma warning( disable : 4305 ) /* '=' : truncation from 'const
> double ' to 'float ' */
> #         pragma warning( disable : 4550 ) /* 'function' undefined;
> assuming extern returning int */
> #         pragma warning( disable : 4761 ) /* integral size mismatch in
> argument; conversion supplied */
> #  endif
> #       if defined(_MSC_VER) && defined(BUILD_GL32) /* tag specify we're
> building mesa as a DLL */
> #               define GLAPI __declspec(dllexport)
> #     define WGLAPI __declspec(dllexport)
> --- end cut ---


In 3.2, gl.h was issuing pragmas.  In 3.3 I moved them into the internal
glheader.h file.

-Brian