[Mesa3d-dev] Re: [Mesa3d-users] Re: Mesa 3.2 for MS-VC, all the fixes

[Brian P. <br...@va...>]

Alessandro Pisani wrote:
> 
> At 15.42 12/07/00, Brian Paul wrote:
> >I have a few problems with this.
> >
> >1. You introduce a new include/GL/mesawin32.h header.  The headers in
> >    include/GL are meant to be public interfaces.  Your header just has
> >    a bunch of MSVC pragmas for compiling Mesa.  This should probably be
> >    moved to the src/ directory.
> >2. When I tried to apply your patch, many of the patches failed since the
> >latest 3.2 CVS files are different from the released 3.2 distro.
> >Can you download the latest files from CVS and try again?
> >3. It would be best if you used the CVS sources since you could then
> >    test/update Mesa 3.3 which will be released soon.
> 
> Mhh...okay: I'll apply them on the latest Mesa 3.3-CVS... but before this
> we've to find a hack for the problem #1... i think moving mesawin32.h into
> /src is complicated : you also have to put something like:
> 
> #ifdef __WIN32__
>   #include "mesawin32.h"
> #endif
> 
> (note that __WIN32__ is defined in gl.h so this code-fragment must be put
> after include <GL/gl.h> )
> 
> in EACH source-file of these dir: /src, /src/FX, /src/FX/X86, /src/X86,
> /demos, /3dfx/demos, /book  etc, etc...
> Please also note that you have to add the code-fragment above in every new
> file you create in Mesa (this is for future), so I think this is not an
> efficient method... is it?

In Mesa 3.3 there's a new src/glheader.h file which is meant to be
the place to put this sort of thing.  It's included by all other source
files.  You should put your pragmas in that file.


> I don't know enough about the Mesa internal structure to find a better
> solution, but if you find a better method (and I'm sure there's one), I'll
> be happy to test it with MS-VC 6.0 ;)

I'm really happy you're doing this work.  I just want to be sure it's
done cleanly.

-Brian